[LU-6349] remove old protocol compatibility Created: 07/Mar/15  Updated: 19/Dec/18  Resolved: 29/May/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0, Lustre 2.11.0, Lustre 2.12.0

Type: Bug Priority: Major
Reporter: Andreas Dilger Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-5974 Remove checksum compatibility with Lu... Resolved
Severity: 3
Rank (Obsolete): 17771

 Description   

It seems that there are some old protocol compatibility workarounds that are still present in master that should have been removed when LUSTRE_MSG_MAGIC_V1 was removed.

In particular, the process for upgrading LUSTRE_MSG_MAGIC_V1 to LUSTRE_MSG_MAGIC_V2 required the client to connect to the server using the V1 protocol first with the MSG_CONNECT_NEXT_VER op_flag set, and if the server supported the V2 protocol it would reply with LUSTRE_MSG_MAGIC_V2. However, even with V1 protocol support removed, the 2.x clients are still always connecting with NEXT_VER set. In b1_8 this flag was contingent on LUSTRE_MSG_MAGIC_V1 being used.

A few other cleanups can be done at the same time:

  • disallow 1.8 clients (or at least those that don't understand OBD_CONNECT_FULL20 features so we can remove workarounds for those old clients
  • remove support for pre-2.1 DLM flock lock handling
  • don't workaround the lack of MDS_ATTR_xTIME_SET flags in setattr
  • always set MSGHDR_CKSUM_INCOMPAT18 (it can eventually be removed)

There are also a lot of places that pretend to allow LUSTRE_MSG_MAGIC_V1 RPCs, but they don't do anything but print an error. They can be cleaned up in a second patch, but i don't want them mixed in with the MSG_CONNECT_NEXT_VER cleanup, since that is important and would prevent us from using this functionality again in the future should we need to upgrade the protocol again.

 Comments   
Comment by Gerrit Updater [ 07/Mar/15 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/14006
Subject: LU-6349 ptlrpc: remove old protocol compatibility
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9cd7eb8a7e518d6d1b3f483f2de867a7ff73d3e8

Comment by Gerrit Updater [ 07/Mar/15 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/14007
Subject: LU-6349 ptlrpc: remove LUSTRE_MSG_MAGIC_V1 support
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7ef3482e67b0a63f11e0537de25a02536377f200

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14006/
Subject: LU-6349 ptlrpc: remove old protocol compatibility
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f4b93dff9a8f4a59976ea864c4e3c2c42faa5770

Comment by Gerrit Updater [ 28/Apr/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14007/
Subject: LU-6349 ptlrpc: remove LUSTRE_MSG_MAGIC_V1 support
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8f1c8dbe2389e1ef1e1d3387e343fb9a1bb84198

Comment by Andreas Dilger [ 29/May/15 ]

Patches landed to master for 2.8.0.

Comment by Gerrit Updater [ 06/Jan/16 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/17830
Subject: LU-6349 idl: clean up and document ptlrpc structures
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b3abe4da0a20eaf299cc6fe5754f1c93aef60afb

Comment by Gerrit Updater [ 06/Jan/16 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/17831
Subject: LU-6349 idl: remove obsolete RPC MSG flags
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: be409236cfb89097a119b77b3b19175a0df70972

Comment by Gerrit Updater [ 17/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/17830/
Subject: LU-6349 idl: clean up and document ptlrpc structures
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e8bdd1a48dd8800d1de0f0daf1e2e38b123de091

Comment by Gerrit Updater [ 17/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/17831/
Subject: LU-6349 idl: remove obsolete RPC MSG flags
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 455ce0cef704e4c9a39bfa9d7c172ca3b31c5fef

Comment by Gerrit Updater [ 21/Jan/18 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/30958
Subject: LU-6349 idl: add PTLRPC definitions to enum
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ccf8290fe5db92f919dde2973d59586f4dd57080

Comment by Gerrit Updater [ 06/Feb/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30958/
Subject: LU-6349 idl: add PTLRPC definitions to enum
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0c9bb26fc4d9157aaa10df2ba0a1796f2e5fc21e

Comment by Gerrit Updater [ 13/Apr/18 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/31984
Subject: LU-6349 mds: remove obsolete MDS_VTX_BYPASS flag
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 74e7d78bb49d7f4743fb1512e088dd12f0900c3f

Comment by Gerrit Updater [ 06/May/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31984/
Subject: LU-6349 mds: remove obsolete MDS_VTX_BYPASS flag
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b99344dda425b78e006c49b1d2b22c75585ca306

Generated at Sat Feb 10 01:59:26 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.