[LU-6353] Push Wireshark Support Upstream Created: 09/Mar/15  Updated: 19/Mar/18  Resolved: 09/Feb/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0, Lustre 2.10.4

Type: Improvement Priority: Minor
Reporter: Doug Oucharek (Inactive) Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: wireshark

Issue Links:
Duplicate
is duplicated by LU-8657 Wireshark dissectors for Lustre fail ... Resolved
Related
is related to LU-6630 ldlm_intent_getattr_client RPC mbo_va... Open
is related to LU-8499 wireshark plugins don't build any more Resolved
is related to LU-4262 intent opcodes not in wire{check,test... Resolved
is related to LU-6582 Wireshark fails to parse LDLM_ENQUEUE... Resolved
is related to LU-6648 Wireshark 1.8.10 does not correctly p... Resolved
is related to LU-6671 Wireshark: LDLM_ENQUEUE reply with un... Resolved
is related to LU-4378 Add HSM message parsing to wireshark ... Resolved
is related to LU-9050 Wireshark build support enhancement Resolved
Rank (Obsolete): 17786

 Description   

It would be good if we can push Wireshark support files upstream (Wireshark project) so we can delete them from our own repository. The two files in question are packet_lnet.c and packet_lustre.c.



 Comments   
Comment by Nathaniel Clark [ 13/Dec/17 ]

I've cleaned up the lnet and lustre wireshark plugins and pushed them up as a patch-chain for wireshark master:
https://code.wireshark.org/review/#/q/topic:plugins-lustre

https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support
https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid
https://code.wireshark.org/review/24797 [lnet] Export shared values from LNET
https://code.wireshark.org/review/24798 [lnet] fix tree types and cleanup NID processing
https://code.wireshark.org/review/24799 [lnet] Fixup definitions from check scripts
https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport
https://code.wireshark.org/review/24801 [lnet] Export NID dissector
https://code.wireshark.org/review/24802 [lnet] Fix payload length for MSG_PUT_REQ
https://code.wireshark.org/review/24803 [lustre] Add MGS opcode dissection
https://code.wireshark.org/review/24804 [lustre] Dissect OBD opcodes
https://code.wireshark.org/review/24805 [lustre] Add LLOG opcode processing
https://code.wireshark.org/review/24806 [lustre] Add QUOTA dissection
https://code.wireshark.org/review/24807 [lustre] Add SEQ dissection
https://code.wireshark.org/review/24808 [lustre] Add OUT, FLD, and SEC dissection
https://code.wireshark.org/review/24809 [lustre] Add LFSCK dissection
https://code.wireshark.org/review/24810 [lustre] Add MDS REINT SETATTR
https://code.wireshark.org/review/24811 [lustre] Ensure subtrees are correctly defined
https://code.wireshark.org/review/24812 [lustre] Add llog eadata dissection

Comment by Nathaniel Clark [ 14/Dec/17 ]

After discussion with Wireshark Devs the above changes have been squashed to the following:
https://code.wireshark.org/review/24796 Infiniband: Fix number of bytes exported if ip_cm_sid
https://code.wireshark.org/review/24795 [lnet] Initial Lustre Network Support
https://code.wireshark.org/review/24800 [lustre] Initial Lustre stupport

Comment by Gerrit Updater [ 19/Dec/17 ]

Nathaniel Clark (nathaniel.l.clark@intel.com) uploaded a new patch: https://review.whamcloud.com/30602
Subject: LU-6353 contrib: Remove wireshark plugin
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ae0bebf5778f6714a28c3b49a2ed950d43352617

Comment by Nathaniel Clark [ 18/Jan/18 ]

All my patches have landed upstream, once we remove the plugins from the lustre tree, this can be closed.

Comment by Gerrit Updater [ 09/Feb/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30602/
Subject: LU-6353 contrib: Remove wireshark plugin
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b5206bcf18c71ecc1291219af560298bf7517e3

Comment by Peter Jones [ 09/Feb/18 ]

Landed for 2.11

Comment by Gerrit Updater [ 09/Feb/18 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31258
Subject: LU-6353 contrib: Remove wireshark plugin
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 741edd17f945502ad82b97ab9664a382c66d6aab

Comment by Gerrit Updater [ 19/Mar/18 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31258/
Subject: LU-6353 contrib: Remove wireshark plugin
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: e744675fbd4e6d50611816c72055c84c4f4fd303

Generated at Sat Feb 10 01:59:28 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.