[LU-6354] Oops in mdd_changelog_ns_store()

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: John Hammond
• Resolution: Fixed
• Labels: mdd
• Severity: 3

Description

In mdd_changelog_ns_store() the sfid parameter may be NULL (for link, unlink, and create). In these cases if mdd_changelog_store() fails then we oops we setting up for the CERROR():

        rc = mdd_changelog_store(env, mdd, rec, handle);
        if (rc < 0) {
                CERROR("changelog failed: rc=%d, op%d %s c"DFID" p"DFID"\n",
                        rc, type, tname->ln_name, PFID(sfid), PFID(tpfid));
                return -EFAULT;
        }

[288638.169877] Lustre: DEBUG MARKER: start dir: /mnt/lustre/lockdir=180144539145611093 file: /mnt/lustre/lockdir/lockfile=180144539145611091
[288676.107130] LustreError: 15139:0:(osd_io.c:1647:osd_ldiskfs_write_record()) loop0: error reading offset 5689344 (block 1389): rc = -28
[288676.109452] LustreError: 15139:0:(llog_cat.c:345:llog_cat_add_rec()) llog_write_rec -28: lh=ffff8801faf5dda8
[288676.111306] BUG: unable to handle kernel NULL pointer dereference at 000000000000000c
[288676.112272] IP: [<ffffffffa0d61ba3>] mdd_changelog_ns_store+0x243/0x610 [mdd]
[288676.112272] PGD 191295067 PUD 1faad8067 PMD 0 
[288676.112272] Oops: 0000 [#1] SMP 
[288676.112272] last sysfs file: /sys/devices/system/cpu/possible
[288676.112272] CPU 2 
[288676.112272] Modules linked in: lustre(U) ofd(U) osp(U) lod(U) ost(U) mdt(U) mdd(U) mgs(U) osd_ldiskfs(U) ldiskfs(U) lquota(U) lfsck(U) obdecho(U) mgc(U) lov(U) osc(U) mdc(U) lmv(U) fid(U) fld(U) ptlrpc(U) obdclass(U) ksocklnd(U) lnet(U) libcfs(U) ext2 exportfs jbd sha512_generic sha256_generic autofs4 nfs lockd fscache auth_rpcgss nfs_acl sunrpc ipv6 zfs(U) zcommon(U) znvpair(U) zavl(U) zunicode(U) spl(U) zlib_deflate microcode virtio_balloon virtio_net i2c_piix4 i2c_core ext4 jbd2 mbcache virtio_blk virtio_pci virtio_ring virtio pata_acpi ata_generic ata_piix dm_mirror dm_region_hash dm_log dm_mod [last unloaded: libcfs]
[288676.112272] 
[288676.112272] Pid: 15139, comm: mdt01_015 Tainted: G        W  ---------------    2.6.32-431.29.2.el6.lustre.x86_64 #1 Bochs Bochs
[288676.112272] RIP: 0010:[<ffffffffa0d61ba3>]  [<ffffffffa0d61ba3>] mdd_changelog_ns_store+0x243/0x610 [mdd]
[288676.112272] RSP: 0018:ffff880191c15a40  EFLAGS: 00010286
[288676.112272] RAX: 00000000ffffffe4 RBX: ffff8801e02a8908 RCX: 0000000000000000
[288676.112272] RDX: 0000000280008100 RSI: ffff8801e090d540 RDI: ffffffffa0d9c600
[288676.112272] RBP: ffff880191c15ae0 R08: 0000000000000000 R09: 0000000000000001
[288676.112272] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8801d58f0b90
[288676.112272] R13: ffff880142b2fc50 R14: ffff88012458b870 R15: ffff8801d9981c30
[288676.112272] FS:  0000000000000000(0000) GS:ffff88002fc00000(0000) knlGS:0000000000000000
[288676.112272] CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
[288676.112272] CR2: 000000000000000c CR3: 00000001e94c9000 CR4: 00000000000006e0
[288676.112272] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[288676.112272] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[288676.112272] Process mdt01_015 (pid: 15139, threadinfo ffff880191c14000, task ffff8801b0c0a7c0)
[288676.112272] Stack:
[288676.112272]  ffff8801e090c818 0000000000000246 0000000280008100 ffff880100002755
[288676.112272] <d> ffff880100000000 ffff8801e02a8908 ffff8801d9981c30 0000000000000000
[288676.112272] <d> ffff880100005000 ffffffff810a44e3 ffff8801ef69d340 00000003d931fda8
[288676.112272] Call Trace:
[288676.112272]  [<ffffffff810a44e3>] ? up_write+0x23/0x40
[288676.112272]  [<ffffffffa0d6b27e>] mdd_link+0xdee/0x1100 [mdd]
[288676.112272]  [<ffffffffa0dd70e9>] mdt_reint_link+0x999/0xbf0 [mdt]
[288676.112272]  [<ffffffffa0dce98c>] ? mdt_root_squash+0x2c/0x3f0 [mdt]
[288676.112272]  [<ffffffffa0863065>] ? __req_capsule_get+0x165/0x6e0 [ptlrpc]
[288676.112272]  [<ffffffffa0dd2c3d>] mdt_reint_rec+0x5d/0x200 [mdt]
[288676.112272]  [<ffffffffa0db86a3>] mdt_reint_internal+0x4d3/0x7b0 [mdt]
[288676.112272]  [<ffffffffa0db8e1b>] mdt_reint+0x6b/0x120 [mdt]
[288676.112272]  [<ffffffffa089d06e>] tgt_request_handle+0x8ce/0x1020 [ptlrpc]
[288676.112272]  [<ffffffffa084db3a>] ptlrpc_main+0xe1a/0x1980 [ptlrpc]
[288676.112272]  [<ffffffffa084cd20>] ? ptlrpc_main+0x0/0x1980 [ptlrpc]
[288676.112272]  [<ffffffff8109e856>] kthread+0x96/0xa0
[288676.112272]  [<ffffffff8100c30a>] child_rip+0xa/0x20
[288676.112272]  [<ffffffff815562e0>] ? _spin_unlock_irq+0x30/0x40
[288676.112272]  [<ffffffff8100bb10>] ? restore_args+0x0/0x30
[288676.112272]  [<ffffffff8109e7c0>] ? kthread+0x0/0xa0
[288676.112272]  [<ffffffff8100c300>] ? child_rip+0x0/0x20
[288676.112272] Code: a0 c7 05 95 aa 03 00 00 00 02 00 41 8b 56 0c 48 8b 4d 10 48 8b 75 20 89 54 24 20 41 8b 56 08 89 54 24 18 49 8b 16 48 89 54 24 10 <8b> 51 0c 89 54 24 08 8b 51 08 89 14 24 4c 8b 09 89 c2 4c 8b 06 
[288676.112272] RIP  [<ffffffffa0d61ba3>] mdd_changelog_ns_store+0x243/0x610 [mdd]
[288676.112272]  RSP <ffff880191c15a40>
[288676.112272] CR2: 000000000000000c

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14027
Subject: LU-6354 mdd: use cr_tfid on error in mdd_changelog_ns_store()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 645910a0c41fc8e9c6fc78c39effc1e4d67a3a45

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14027/
Subject: LU-6354 mdd: use cr_tfid on error in mdd_changelog_ns_store()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c7f1a96010fd2243fa0b301543862e70784f7b35

[Peter Jones]

Landed for 2,8