[LU-6388] llog_reader cannot parse changelog records

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.7.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Olaf Faaland
• Assignee: Emoly Liu
• Resolution: Fixed
• Labels: llnl, llnlfixready, patch
• Severity: 3

Description

llog_reader does not handle records of type CHANGELOG_REC or CHANGELOG_USER_REC. In addition, its output for records in the changelog_catalog (type LLOG_LOGID_MAGIC) is more obscure than it needs to be.

The change submitted adds support for those unhandled record types. It also provides the actual pathname to the lustre log containing changelog records, that one would need when mounting an ldiskfs or zfs target via the posix layer for inspection.

Comments

[Olaf Faaland]

Patch to be submitted to gerrit RSN.

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14120
Subject: LU-6388 utils: make llog_reader parse changelogs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 21eaccd05daa592572eb0ee99146194219bd09cc

[Olaf Faaland]

Submitted the patch, link above.

I'll check with Li Xi re: LU-632 which touches some of the same areas of code to resolve the conflict. I've left the space indentation in the functions alone, because I think changing it obscures content in the diff view, but I'll address style after any content issues are identified and corrected.

[Peter Jones]

Emoly

Could you please take care of this patch?

Thanks

Peter

[Olaf Faaland]

Hello Emoly,

Please suggest a next step.

Lustre-initialization-1 within review-zfs failed because mkfs.lustre failed to initialize the ZFS OSD on shadow-21vm7 (the OSS).

Looking at the syslog files for 21vm7 (OSS) and 21vm8 (MDS) I see that yum installed the lustre-osd-zfs-mount and lustre-osd-zfs packages on 21vm8 but not on 21vm7.

This patch does not touch the zfs OSD in any way, and local testing via llmount.sh with FSTYPE=zfs is successful. See below from lustre-initialization-1.suite_stdout.shadow-21vm9.log

lustre-initialization-1.suite_stdout.shadow-21vm9.log:00:33:15:CMD: shadow-21vm7 mkfs.lustre --mgsnode=shadow-21vm8@tcp --fsname=lustre --ost --index=0 --param=sys.timeout=20 --backfstype=zfs --device-size=8388608 --reformat lustre-ost1/ost1 /dev/lvm-Role_OSS/P1
lustre-initialization-1.suite_stdout.shadow-21vm9.log:00:33:15:shadow-21vm7: mkfs.lustre FATAL: unhandled fs type 5 'zfs'
lustre-initialization-1.suite_stdout.shadow-21vm9.log:00:33:15:shadow-21vm7: mkfs.lustre FATAL: unable to prepare backend (22)
lustre-initialization-1.suite_stdout.shadow-21vm9.log:00:33:15:shadow-21vm7: mkfs.lustre: exiting with 22 (Invalid argument)

So it looks like the script that sets up the test environment failed to generate the correct yum install commands on the oss node.

Please let me know how to address this.

thanks,
Olaf

[Emoly Liu]

Olaf, I will re-trigger the test and see if this error happens again.

[Olaf Faaland]

Hi Emoly,
Please review the patch when you get a chance.
thanks,
-Olaf

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14120/
Subject: LU-6388 utils: make llog_reader parse changelogs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bd61b6f1bb9848167d0cdecb22099856c3ad98ca

[Joseph Gmitter (Inactive)]

Landed for 2.8.

[D. Marc Stearman (Inactive)]

Olaf, Chris, do we have this patch in our local release?

[Olaf Faaland]

Marc,

Yes, this patch is in lustre 2.5.5-3chaos (included in toss 2.4-6.ch5.4) and I believe was in earlier releases as well.

-Olaf