[LU-6410] Replace the quota-replace-dqptr-sem.patch with upstream one Created: 30/Mar/15 Updated: 19/Jul/17 Resolved: 19/Jul/17 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Niu Yawei (Inactive) | Assignee: | Niu Yawei (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
The quota-replace-dqptr-sem.patch adds additional dquot reference count in __dquot_alloc/free_space(), dquot_alloc/free_inode(), and calls dqput() to put the refcount on function exit. The purpose was to avoid used after free problem on the dquot, however, that change added dqput() calls for each inode/space alloc/free operations, and I'm afraid that'll contribute to global lock contention. (dqput() holds dq_list_lock) The upstream version uses srcu_lock() to avoid the problem of use after free on dquot, no additional dqput() calls. |
| Comments |
| Comment by Niu Yawei (Inactive) [ 19/Jul/17 ] |
|
Drop it base on re-evaluation. |