[LU-6418] Simplify code of ll_direct_rw_pages Created: 31/Mar/15 Updated: 08/Feb/18 Resolved: 08/Feb/18 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Trivial |
| Reporter: | wu libin (Inactive) | Assignee: | Jinshan Xiong (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
In function ll_direct_rw_pages, the cl_page_find will return a cl_page with cp_type of CPT_TRANSIENT for sure. And we will not cache this type of cl_page anymore. So, i think we could remove the code of the logical when the cp_type is equal CPT_CACHABLE which is the code need in old version that cached the cl_page into the radix tree no matter what the type is. |
| Comments |
| Comment by Gerrit Updater [ 31/Mar/15 ] |
|
Wu Libin (gnlwlb@gmail.com) uploaded a new patch: http://review.whamcloud.com/14288 |
| Comment by Peter Jones [ 02/Apr/15 ] |
|
Jinshan has provided feedback on the patch in gerrit |
| Comment by Jinshan Xiong (Inactive) [ 02/Apr/15 ] |
|
Please reopen this ticket if anything new comes up. |
| Comment by wu libin (Inactive) [ 03/Apr/15 ] |
|
Hi, Jinshan, from the code of cl_page_find, it seems that cp_type of the cl_page impossible to be CPT_CACHEABLE here.So the codes of the "if (clp->cp_type == CPT_CACHEABLE)" branch are redundant, right? Please take a look at it again, sorry if i have missed something. |
| Comment by Jinshan Xiong (Inactive) [ 03/Apr/15 ] |
|
indeed, I forgot that we have changed cl_page_find() implementation. Yes, your patch is correct. |
| Comment by wu libin (Inactive) [ 04/Apr/15 ] |
|
sure, thanks! |
| Comment by Jinshan Xiong (Inactive) [ 08/Feb/18 ] |
|
The work should be already in Lustre. |