[LU-6498] Redundant rc check in ll_setattr_raw Created: 25/Apr/15 Updated: 07/Jun/17 Resolved: 30/May/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | WC Triage |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy, hackathon2017 | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
It looks like we had a bit of a strange code before SOM removal that is even more redundant now in ll_Setattr_raw: rc = ll_md_setattr(dentry, op_data);
if (rc)
GOTO(out, rc);
/* RPC to MDT is sent, cancel data modification flag */
if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
spin_lock(&lli->lli_lock);
lli->lli_flags &= ~LLIF_DATA_MODIFIED;
spin_unlock(&lli->lli_lock);
}
So I guess the rc ==0 part could go easily? |
| Comments |
| Comment by Ben Evans (Inactive) [ 30/May/17 ] |
|
This code has been removed. |