[#LU-6501] nidstrings always true comparisons

[LU-6501] nidstrings always true comparisons Created: 27/Apr/15 Updated: 25/Jul/15 Resolved: 25/Jul/15
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.8.0

Type:

Bug

Priority:

Minor

Reporter:

Oleg Drokin

Assignee:

WC Triage

Resolution:

Fixed

Votes:

Labels:

patch

Issue Links:

Blocker
is blocked by	~~LU-6744~~	conf-sanity test_51:(lov_object.c:945...	Resolved
Related
is related to	~~LU-6245~~	Untangle userland and kernel space su...	Resolved

Severity:

Rank (Obsolete):

9223372036854775807

Description

Running smatch I see these three warnings in recently introduced nidstrings.c:

/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:360 libcfs_namenum2netstrfns() warn: always true condition '(nf->nf_type >= 0) => (0-u32max >= 0)'
/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:373 libcfs_name2netstrfns() warn: always true condition '(libcfs_netstrfns[i]->nf_type >= 0) => (0-u32max >= 0)'
/home/green/smt/git/lustre-release/lnet/lnet/nidstrings.c:487 libcfs_str2net_internal() warn: always true condition '(nf->nf_type >= 0) => (0-u32max >= 0)'

Comments

Comment by James A Simmons [ 27/Apr/15 ]

This is most likely broken in libcfs/libcfs/util/nidstrings.c as well.

Comment by Gerrit Updater [ 29/Jun/15 ]

Frederic Saunier (frederic.saunier@atos.net) uploaded a new patch: http://review.whamcloud.com/15424
Subject: ~~LU-6501~~ libcfs: break off loop at end of libcfs_netstrfns[]
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0726936d537c77d8a40115dd3de8c54560e556fe

Comment by James Nunez (Inactive) [ 23/Jul/15 ]

Could this bug be causing conf-sanity test 43 to fail? One of the failures is at:
https://testing.hpdd.intel.com/test_sets/59a5d976-30b7-11e5-ae23-5254006e85c2

Comment by Gerrit Updater [ 25/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15424/
Subject: ~~LU-6501~~ libcfs: removal last entry of libcfs_netstrfns[]
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5628f0cb3fd2960f4a5effdf9b9d7b4bd9357713

Comment by Peter Jones [ 25/Jul/15 ]

Landed for 2.8

Generated at Sat Feb 10 02:00:46 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.

[LU-6501] nidstrings always true comparisons Created: 27/Apr/15 Updated: 25/Jul/15 Resolved: 25/Jul/15