[LU-6509] dead code in nodemap_create

• Status: Open
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: WC Triage
• Resolution: Unresolved
• Severity: 3

Description

Highlighted by smatch in nodemap_create:

...
        rc = nm_member_init_hash(nodemap);
        if (rc != 0) {
                OBD_FREE_PTR(nodemap);
                goto out;
        }
... (not touching rc at all)
        if (rc == 0) {
                nodemap_putref(nodemap);
                goto out;
        }

        CERROR("cannot add nodemap: '%s': rc = %d\n", name, rc);
        nodemap_destroy(nodemap);

out:
        return rc;

I wonder if this is a stub waiting for some more code or something was forgotten or what?

Comments

[Oleg Drokin]

Also in lprocfs_add_nodemap_range_seq_write:

        rc = nodemap_add_range(name, nids);
        if (rc != 0)
                GOTO(out, rc = -EINVAL);

        if (rc == 0)
                rc = count;

out:
        return rc;

Why do we need that last "if" again?

[Oleg Drokin]

and the same in lprocfs_add_nodemap_idmap_seq_write and lprocfs_del_nodemap_idmap_seq_write