[LU-6512] ll_dir_ioctl has some pretty strange code now. Created: 27/Apr/15  Updated: 03/May/16  Resolved: 03/May/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: easy, patch

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

smatch highlighted thid interesting piece in ll_dir_ioctl that results from a bit of code change by commit 60e07b972114df24105a3a1bfa7365892f72a4a7 LU-4690:

                rc = ll_dir_getstripe(inode, (void **)&lmm, &lmmsize, &request,
                                      valid);
                if (rc != 0)
                        GOTO(finish_req, rc);

                /* Get default LMV EA */
                if (lum.lum_magic == LMV_USER_MAGIC) {
                        if (rc != 0)
                                GOTO(finish_req, rc);

note the two identical comparisons.
Should we take the other one down?

 Comments   
Comment by Ulka Vaze (Inactive) [ 21/May/15 ]

Hi,
this seems to be some merging issue.
I will check and update.

-Ulka

Comment by Gerrit Updater [ 18/Jan/16 ]

Parinay Kondekar (parinay.kondekar@seagate.com) uploaded a new patch: http://review.whamcloud.com/18027
Subject: LU-6512 ll_dir_ioctl cleanup of redundant comparisions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 909db31ed1407f266765a7575f3dd7a2f91cd4aa

Comment by Gerrit Updater [ 02/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18027/
Subject: LU-6512 llite:ll_dir_ioctl cleanup of redundant comparisons
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c341ac9083c1764675c92363e1dd8bcd3223788a

Comment by Joseph Gmitter (Inactive) [ 03/May/16 ]

Landed to master for 2.9.0

Generated at Sat Feb 10 02:00:51 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.