[LU-6522] doble semaphore unlock in loop_thread Created: 27/Apr/15  Updated: 30/Jan/22  Resolved: 30/Jan/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: WC Triage
Resolution: Not a Bug Votes: 0
Labels: None

Issue Links:
Related
is related to LU-8844 Delete llite lloop with fire!!! Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

smatch has highlighted this gem in loop_thread():

        /*
         * up sem, we are running
         */
        up(&lo->lo_sem);

... {BIG HONKING LOOP} ...
out:
        up(&lo->lo_sem);
        return ret;

I imagine when the loop terminates we don't care anymore, but still it just looks wrong and probably should be fixed?

 Comments   
Comment by Andreas Dilger [ 30/Jan/22 ]

Fixed by patch https://review.whamcloud.com/23817 "LU-8844 llite: delete lloop"

Generated at Sat Feb 10 02:00:56 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.