[LU-6533] Missing include in wirecheck

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Henri Doreau (Inactive)
• Assignee: Nathaniel Clark
• Resolution: Fixed
• Labels: patch
• Severity: 3

Description

wirecheck.c won't build on some platforms due to a missing include.

make: Entering directory `/mnt/build/lustre-release/lustre/utils'
gcc -DHAVE_CONFIG_H -I. -I../.. -DCC="\"gcc\"" -include /mnt/build/lustre-release/config.h -I/mnt/build/lustre-release/libcfs/include -I/mnt/build/lustre-release/lnet/include -I/mnt/build/lustre-release/lustre/include -g -Wall -fPIC -D_GNU_SOURCE -g -O2 -Werror -MT wirecheck-wirecheck.o -MD -MP -MF .deps/wirecheck-wirecheck.Tpo -c -o wirecheck-wirecheck.o `test -f 'wirecheck.c' || echo './'`wirecheck.c
cc1: warnings being treated as errors
wirecheck.c: In function 'system_string':
wirecheck.c:2168: error: implicit declaration of function 'pipe'
wirecheck.c:2172: error: implicit declaration of function 'fork'
wirecheck.c:2177: error: implicit declaration of function 'dup2'
wirecheck.c:2191: error: implicit declaration of function 'close'
make: *** [wirecheck-wirecheck.o] Error 1

Comments

[Gerrit Updater]

Henri Doreau ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14626
Subject: LU-6533 utils: Include unistd.h in wirecheck
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b6b5ec0209dee95c70268e3fdf62a53f3ccfab13

[Henri Doreau (Inactive)]

Patch is at http://review.whamcloud.com/14626

[Peter Jones]

Nathaniel

Could you please take care of this patch?

Thanks

Peter

[James A Simmons]

This is due to the libcfs.h header cleanups. What would be nice is to see libcfs.h to be removed from wire check.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14626/
Subject: LU-6533 utils: Include unistd.h in wirecheck
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1013e80927ef4449d2956461db6502f6192a3a61