[LU-6541] potential memory leak in gssd_get_krb5_machine_cred_list

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Colin Ian King
• Assignee: Dmitry Eremin (Inactive)
• Resolution: Fixed

Environment

Ubuntu 15.04

• Severity: 1

Description

static analysis by cppcheck has found a potential memory leak in gssd_get_krb5_machine_cred_list():

[lustre/utils/gss/krb5_util.c:918]: (error) Common realloc mistake: 'l' nulled but not freed upon failure

listsize += listinc;
l = (char **)
realloc(l, listsize * sizeof(char *));
if (l == NULL)

{ retval = ENOMEM; goto out; }

The semantics of realloc are to return NULL when the allocation fails, but won't free the original allocation:

"The realloc() function returns a pointer to the newly allocated memory,
which is suitably aligned for any built-in type and may be different
from ptr, or NULL if the request fails. If size was equal to 0, either
NULL or a pointer suitable to be passed to free() is returned. If
realloc() fails, the original block is left untouched; it is not freed
or moved."

so, one needs to do something like:

tmp = (char **)realloc(l, listsize * sizeof(char *));
if (tmp)
l = tmp;
else {
retval = ENOMEM;
goto out;
}

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14814/
Subject: LU-6541 utils: fix potential memory leaks with realloc()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 55f2a237320f23cb59df23518f5a72698d4f251c

[Peter Jones]

Landed for 2.8