[LU-6601] deactivated OSTs do not appear to be inactive according to 'lctl dl'

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: Yang Sheng
• Resolution: Fixed
• Labels: easy, lod, osp
• Severity: 3

Description

Following the instructions in Section 19.1.2 of the ops manual I deactivated an OST.

t:~# lctl dl
...
 21 UP osp lustre-OST0000-osc-MDT0000 lustre-MDT0000-mdtlov_UUID 5
 22 UP osp lustre-OST0001-osc-MDT0000 lustre-MDT0000-mdtlov_UUID 5
t:lustre# lctl --device 21 deactivate
t:lustre# lctl dl
...
 21 UP osp lustre-OST0000-osc-MDT0000 lustre-MDT0000-mdtlov_UUID 5
 22 UP osp lustre-OST0001-osc-MDT0000 lustre-MDT0000-mdtlov_UUID 5

Device 21 should be IN instead of UP. This is controlled by the obd_inactive field of struct obd_device which is only modified in the lov layer.

The active proc files do work correctly:

t:lustre# cat /proc/fs/lustre/osp/lustre-OST0000-osc-MDT0000/active 
0
t:lustre# cat /proc/fs/lustre/osp/lustre-OST0001-osc-MDT0000/active 
1

Also note that the examples in the manual need to be updated to reflect the osc to osp switchover.

Issue Links

• is duplicated by: LU-7731 lctl dl - command don't report correc...
• is related to: LU-7668 permanently remove deactivated OSTs f...

Comments

[Ulka Vaze (Inactive)]

Hi John,

What is GBOL ? Can you give me link?

Thanks,
-Ulka

[Peter Jones]

Hi Ulka

It is an joke reference to a comment at a past LUG. He means the Lustre manual.

Peter

[Ulka Vaze (Inactive)]

Thanks for clarification

[Ulka Vaze (Inactive)]

Hi,
I have analyzed this issue; here is prospective solution -
1. lctl dl call reads /proc/fs/lustre/devices file
2. This proc code looks for obd->obd_inactive flag and accordingly sets the status.
3. Whenever we deactivate OST device it is ultimately received by osp
4. At OSP osp_import_event function handles the activation or deactivation of OST
5. However we are not notifying obd to set upcall for state change.
6 We need to register osp_notify function and call obd_notify.

Thanks,
-Ulka

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19402
Subject: LU-6601 osp: update obd status while osp status changed
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 34c353ffb385f50d5088b7cc5b11ccad8eb2ff80

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19402/
Subject: LU-6601 osp: update obd status while osp status changed
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ba2ac3502026fcf7399ac102d24bbb7f3d7a8c87

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/19637
Subject: LU-6601 tests: test case validate OSP status op
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2c793405e86d21dadce17e65d348c45ee226e0d3

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/19637/
Subject: LU-6601 tests: test case validate OSP status op
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f5f62250886e8c68e7f0dee9c2842c3075a69654

[Yang Sheng]

Patch landed, So close this ticket.