[LU-6656] Non atomic allocation under spin lock in qmt_glimpse_lock Created: 27/May/15  Updated: 14/Dec/21  Resolved: 14/Dec/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Patrick Farrell (Inactive) Assignee: WC Triage
Resolution: Not a Bug Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In qmt_glimpse_lock:

While the resource lock (a spin lock) is held, it does

OBD_ALLOC_PTR(work);

This allocation is not atomic, so it can potentially sleep.

Sleeping with a spinlock held is not a good idea in general, and (per Andreas) it is specifically not allowed for GFP_NOFS allocations.



 Comments   
Comment by Gerrit Updater [ 27/May/15 ]

Patrick Farrell (paf@cray.com) uploaded a new patch: http://review.whamcloud.com/14974
Subject: LU-6656 qmt: Fix non-atomic allocation under lock
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: adc86369e7df08dd71bb9fa605554f7ffa44ef1f

Generated at Sat Feb 10 02:02:05 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.