[LU-666] mdd depends on ldiskfs-only dynlocks feature

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.2.0
• Type: Bug
• Priority: Minor
• Reporter: Brian Behlendorf
• Assignee: Lai Siyao
• Resolution: Fixed
• Story Points: 1
• Severity: 3
• Bugzilla ID: 22,435
• Epic: server
• Project: Orion

Description

As discussed in Lustre bugzilla 22435 dynlocks are provided by the ldiskfs and are not a generic facility. They should be removed from the mdd-level to allow building --without-ldiskfs per Andreas's comment in 22435:

https://bugzilla.lustre.org/show_bug.cgi?id=22435#c3

This change converts the instances of "struct dynlock_handle *" to a "void *" pointer which is safe because they are never dereferenced at this level.

It also wraps the "struct dynlock" entry in the mdd_object with MDD_DISABLE_PDO_LOCK. This effectively limits all direct dynlock usage to the !MDD_DISABLE_PDO_LOCK case which is unconditionally disabled in the code. Presumable this code will simply be removed at some point which will fully resolve the issue.

Comments

[Brian Behlendorf]

http://review.whamcloud.com/1348

[Peter Jones]

Lai

Could you please look into this one?

Thanks

Peter

[Peter Jones]

Landed for 2.2

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_internal.h
• lustre/mdd/mdd_lock.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_internal.h
• lustre/mdd/mdd_lock.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_internal.h
• lustre/mdd/mdd_lock.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #295
LU-666 mdd depends on ldiskfs-only dynlocks feature

Oleg Drokin : 69efa174743f5ad2425c0ccd951961ae356fed0d
Files :

• lustre/mdd/mdd_lock.c
• lustre/mdd/mdd_internal.h