[LU-6662] mkfs should allow use of errors=panic Created: 28/May/15 Updated: 12/May/16 Resolved: 18/Dec/15 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.3 |
| Fix Version/s: | Lustre 2.8.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Mahmoud Hanafi | Assignee: | Hongchao Zhang |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy | ||
| Issue Links: |
|
||||||||||||||||
| Severity: | 3 | ||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
mkfs.lustre defaults mountoptions to error=mount-ro and doesn't allow error=panic. Changing this using tunefs.lustre also gives warning about 'error=mount-ro' is missing. Is the use of error=panic discouraged? if so why? |
| Comments |
| Comment by Peter Jones [ 28/May/15 ] |
|
Hongchao Could you please advise on this one? Thanks Peter |
| Comment by Andreas Dilger [ 28/May/15 ] |
|
I don't think errors=panic is discouraged, this is likely just an oversight from the time when the errors=remount-ro option was never being specified and the warning message was added to ensure that this wasn't missed. To fix this problem, I think the right approach is to change the code to check for any errors= option being specified. However, this is complicated by the way that the code is currently implemented, since for it sets errors=remount-ro into default_mountopts in ldiskfs_prepare_lustre(), and then later checks in check_mountfsoptions() whether those default options are present. There isn't really an easy way to change this currently, though I think it would be better to change the osd_prepare_lustre() method to be passed only actual mountopts string, ldd_mount_opts[] and its maximum size, instead of passing the default_mountopts and always_mountopts back to the caller. That would allow ldiskfs_prepare_lustre() to verify the mountopts string to handle cases like this, store the defaults into ldd_mount_opts[], and append any user-specified values to override the default values. |
| Comment by Gerrit Updater [ 06/Aug/15 ] |
|
Hongchao Zhang (hongchao.zhang@intel.com) uploaded a new patch: http://review.whamcloud.com/15870 |
| Comment by Jay Lan (Inactive) [ 16/Oct/15 ] |
|
The conf-sanity.sh in 2.5.3 contains only up to test_77. Is it OK to just pick up test_88 added in #15870? |
| Comment by Andreas Dilger [ 16/Oct/15 ] |
|
Yes, each subtest should be self-contained. |
| Comment by Mahmoud Hanafi [ 16/Oct/15 ] |
|
This LU can be closed |
| Comment by Peter Jones [ 16/Oct/15 ] |
|
Thanks Mahmoud but, given that there is a patch that - as far as I understand - you are using we should probably hold this open until that has landed to master |
| Comment by Gerrit Updater [ 18/Dec/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15870/ |
| Comment by Joseph Gmitter (Inactive) [ 18/Dec/15 ] |
|
Landed for 2.8 |