[LU-6691] distribute_txn_commit_batchid_init references ERR_PTR on error path Created: 05/Jun/15  Updated: 14/Jul/15  Resolved: 14/Jul/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Critical
Reporter: Oleg Drokin Assignee: Di Wang
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Recently landed patch http://review.whamcloud.com/11572 has these problems:

/home/green/smt/git/lustre-release/lustre/ptlrpc/../../lustre/target/update_trans.c:1216 distribute_txn_commit_batchid_init() error: 'dt_obj' dereferencing possible ERR_PTR()

code:

        dt_obj = dt_find_or_create(env, lut->lut_bottom, fid, dof,
                                   attr);
        if (IS_ERR(dt_obj))
                GOTO(out_put, rc = PTR_ERR(dt_obj));
...
out_put:
        if (rc < 0 && dt_obj != NULL) {
                lu_object_put(env, &dt_obj->do_lu);

This is clearly wrong.

 Comments   
Comment by Di Wang [ 14/Jul/15 ]

this has been fixed by http://review.whamcloud.com/#/c/12825/, which has landed to master.

Generated at Sat Feb 10 02:02:24 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.