[LU-6714] llog_process_thread() may use wrong offset for the next block Created: 12/Jun/15 Updated: 10/Apr/17 Resolved: 11/Aug/15 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.8.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Mikhail Pershin | Assignee: | Mikhail Pershin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Severity: | 3 | ||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
the llog_process_thread() save curent offset in last_offset variable before getting the new block of data, and uses it as the beginning of that block later. That can be wrong because new block can be read from different offset, depending on index being searched. We need to use the value returned by llog_next_block() call. |
| Comments |
| Comment by Mikhail Pershin [ 12/Jun/15 ] |
|
It worths also to modify llog processing for the llog with fixed size records. For such llogs needed records can be accessed by index like in array, so we have file offset of record just by index, no need to search it going through whole llog. |
| Comment by Mikhail Pershin [ 14/Jun/15 ] |
|
Link |
| Comment by Gerrit Updater [ 16/Jun/15 ] |
|
Mike Pershin (mike.pershin@intel.com) uploaded a new patch: http://review.whamcloud.com/15316 |
| Comment by Gerrit Updater [ 10/Jul/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15316/ |
| Comment by Peter Jones [ 10/Jul/15 ] |
|
Landed for 2.8 |
| Comment by Gerrit Updater [ 03/Aug/15 ] |
|
Mike Pershin (mike.pershin@intel.com) uploaded a new patch: http://review.whamcloud.com/15835 |
| Comment by Gerrit Updater [ 04/Aug/15 ] |
|
Mike Pershin (mike.pershin@intel.com) uploaded a new patch: http://review.whamcloud.com/15841 |
| Comment by Andreas Dilger [ 04/Aug/15 ] |
|
Looks like the http://review.whamcloud.com/15841 patch is not landed yet. |
| Comment by Gerrit Updater [ 09/Aug/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15841/ |
| Comment by Mikhail Pershin [ 11/Aug/15 ] |
|
fix was landed |
| Comment by Peter Jones [ 12/Aug/15 ] |
|
Mike Doesn't this ticket need to remain open until http://review.whamcloud.com/#/c/15835/ lands? Or can this work be abandoned or tracked under another ticket #? Peter |
| Comment by Mikhail Pershin [ 14/Aug/15 ] |
|
this ticket can be closed, the patch you mentioned is under different ticket already |
| Comment by Gerrit Updater [ 18/Aug/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15835/ |
| Comment by Gerrit Updater [ 07/Sep/15 ] |
|
Mike Pershin (mike.pershin@intel.com) uploaded a new patch: http://review.whamcloud.com/16287 |
| Comment by Gerrit Updater [ 07/Sep/15 ] |
|
Mike Pershin (mike.pershin@intel.com) uploaded a new patch: http://review.whamcloud.com/16288 |
| Comment by Gerrit Updater [ 13/Dec/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16287/ |