[LU-6816] libzfs_load_module() not exported in future ZFS release Created: 08/Jul/15  Updated: 28/Sep/15  Resolved: 16/Jul/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.7.0
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Olaf Faaland Assignee: Jinshan Xiong (Inactive)
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Blocker
is blocking LU-7153 Update ZFS/SPL version to 0.6.5.2 Resolved
Duplicate
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

zfs_init() currently calls libzfs_load_module(), which is no longer externally visible in ZFS master.

The intent of the call to libzfs_load_module apparently is to make zfs_init() fail silently if libzfs is not installed, but fail with an error message if libzfs is installed but initialization fails. However it's not clear how this could ever work.

In addition, I believe this could be better addressed by not reporting errors during probing, but instead reporting them only after osd_is_lustre() fails.

A patch will be submitted to remove the invalid call, and a separate ticket for the revamp of the osd initialization error handling.



 Comments   
Comment by Gerrit Updater [ 09/Jul/15 ]

Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: http://review.whamcloud.com/15539
Subject: LU-6816 utils: remove libzfs_load_module() call
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d314049bb5215e7bf722ca73d047d20a8aa5b8d5

Comment by Olaf Faaland [ 09/Jul/15 ]

This appears to be a dupe of CORRAIDZ-5 / Change 15324. Since I can't see that ticket, though, I'll keep this open temporarily until the patch is merged.

Comment by Peter Jones [ 09/Jul/15 ]

Jinshan

It looks like this request duplicates a task tracked for CORAL. Of course we will need to use an LU ticket to track any landings to master so I suggest that you use this LU reference and add any extra details necessary to this LU ticket.

Thanks

Peter

Comment by Olaf Faaland [ 09/Jul/15 ]

I submitted an update to gerrit that didn't automatically update this ticket. Details are:

Subject: LU-6816 utils: remove libzfs_load_module() call
Project: fs/lustre-release
Branch: master
Current Patch Set: 3
patch: http://review.whamcloud.com/#/c/15324/
Commit 97bbd4c447e4034e876fc6f993e27ff3e6f0ea9d

Comment by Gerrit Updater [ 16/Jul/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15539/
Subject: LU-6816 utils: remove libzfs_load_module() call
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b70236ecb9f51c49795d7c15819c9184cdc16e6

Generated at Sat Feb 10 02:03:29 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.