[LU-6873] Double mutex unlock in lod_add_device

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: Di Wang
• Resolution: Fixed
• Severity: 3

Description

Seems there's a double mutex unlock on error path in lod_add_device.
Also in the same vein, there seems to be double reference drop

        cfs_bitmap_set(ltd->ltd_tgt_bitmap, index);
        ltd->ltd_tgtnr++;
        mutex_unlock(&ltd->ltd_mutex);
        lod_putref(lod, ltd);
...
        if (!for_ost && lod->lod_initialized) {
                rc = lod_sub_init_llog(env, lod, tgt_desc->ltd_tgt);
                if (rc != 0) {
                        CERROR("%s: cannot start llog on %s:rc = %d\n",
                               lod2obd(lod)->obd_name, osp, rc);
**                        GOTO(out_pool, rc);
                }
        }
        rc = lfsck_add_target(env, lod->lod_child, d, exp, index, for_ost);
        if (rc != 0) {
                CERROR("Fail to add LFSCK target: name = %s, type = %s, "
                       "index = %u, rc = %d\n", osp, type, index, rc);
**                GOTO(out_fini_llog, rc);
...
out_fini_llog:
        lod_sub_fini_llog(env, tgt_desc->ltd_tgt,
                          tgt_desc->ltd_recovery_thread);
out_pool:
        lod_ost_pool_remove(&lod->lod_pool_info, index);
out_mutex:
        mutex_unlock(&ltd->ltd_mutex);
        lod_putref(lod, ltd);

So we do double unlock and double reference put in those two cases which is probably a pretty bad idea,

Comments

[Joseph Gmitter (Inactive)]

Fan Yong,

You you please have look at this issue?

Thanks.
Joe

[nasf (Inactive)]

This issue is introduced by the DNE patch http://review.whamcloud.com/11408.

Wang Di, would you please to re-work your patch? Thanks!

[Gerrit Updater]

wangdi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16067
Subject: LU-6873 lod: duplicate mutex unlock
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: daca6187188b5ed42dfd088f9b5f4438eb3f5f0b

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16067/
Subject: LU-6873 lod: duplicate mutex unlock
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0ab9e68328e2cfbcf4f891d68055b9243a1f553c

[Joseph Gmitter (Inactive)]

Landed for 2.8.