[LU-6879] tgt_request_handle has unnecessary req->export != NULL check Created: 19/Jul/15  Updated: 24/Mar/16  Resolved: 24/Mar/16

Status: Closed
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Gregoire Pichon
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Added by recent multislot code:

        tsi->tsi_tgt = tgt = class_exp2tgt(req->rq_export);
...
        /* check request's xid is consistent with export's last_xid */
        if (req->rq_export != NULL) {
...

At this point we certainly cannot have NULL req->rq_export so that condition is totally unneeded.

 Comments   
Comment by Gerrit Updater [ 21/Jul/15 ]

Grégoire Pichon (gregoire.pichon@bull.net) uploaded a new patch: http://review.whamcloud.com/15661
Subject: LU-6879 ptlrpc: fix last_xid handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 508688d59ff5b8111e9a8dcb529922dd453ae8a5

Comment by Gregoire Pichon [ 04/Jan/16 ]

This ticket can be closed since the patch http://review.whamcloud.com/#/c/16759/ updates that portion of code and removes the unneeded condition. This patch was merged on 09/Dec/2015.

Generated at Sat Feb 10 02:04:04 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.