[LU-6881] sub_trans_commit_cb() is racy

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Critical
• Reporter: Niu Yawei (Inactive)
• Assignee: Di Wang
• Resolution: Fixed
• Severity: 3

Description

sub_trans_commit_cb() can be called by in parallel, so all_committed could be set to false even if all sub transactions are committed.

static void sub_trans_commit_cb(struct lu_env *env,
                                struct thandle *sub_th,
                                struct dt_txn_commit_cb *cb, int err)
{
        struct sub_thandle      *st;
        struct top_multiple_thandle *tmt = cb->dcb_data;
        bool                    all_committed = true;
        ENTRY;

        /* Check if all sub thandles are committed */
        list_for_each_entry(st, &tmt->tmt_sub_thandle_list, st_sub_list) {
                if (st->st_sub_th == sub_th) {
                        st->st_committed = 1;
                        st->st_result = err;
                }
                if (!st->st_committed)
                        all_committed = false;
        }

        if (tmt->tmt_result == 0)
                tmt->tmt_result = err;

        if (all_committed)
                top_trans_committed_cb(tmt);

        top_multiple_thandle_dump(tmt, D_INFO);
        top_multiple_thandle_put(tmt);
        RETURN_EXIT;
}

Comments

[Gerrit Updater]

wangdi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15690
Subject: LU-6881 update: add lock to protect commit check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b351081da4835a6d6d3ccd8f9bebe4e60c591740

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15690/
Subject: LU-6881 update: add lock to protect commit check
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 58c571070e72c6912aea47da5d90e7365d626d6b