[LU-6888] osp_update_request_create() should check return value

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Niu Yawei (Inactive)
• Assignee: Niu Yawei (Inactive)
• Resolution: Fixed
• Severity: 3

Description

struct osp_update_request *osp_update_request_create(struct dt_device *dt)
{
        struct osp_update_request *our;

        OBD_ALLOC_PTR(our);
        if (our == NULL)
                return ERR_PTR(-ENOMEM);

        INIT_LIST_HEAD(&our->our_req_list);
        INIT_LIST_HEAD(&our->our_cb_items);
        INIT_LIST_HEAD(&our->our_list);

        osp_object_update_request_create(our, OUT_UPDATE_INIT_BUFFER_SIZE);
        return our;
}

osp_update_request_create() doesn't check the return value of osp_object_update_request_create(), so it could return a 'our' without 'ours_request' attached if memory allocation failed in osp_object_update_request_create().

But all the callers of osp_update_request_create() assumes the 'our' must have 'ours_request' attached. See osp_insert_async_request() or osp_update_rpc_pack().

Issue Links

• is related to: LU-6831 The ticket for tracking all DNE2 bugs

Comments

[Di Wang]

Niu: could you please help here? thanks

[Gerrit Updater]

Niu Yawei ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20941
Subject: LU-6888 osp: check return value in osp_update_request_create()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f58f80798b9db95f5ba6c2590b865784e431c61f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/20941/
Subject: LU-6888 osp: check return value in osp_update_request_create()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e2462a1286fb83dd7c0362ac8f88d380c058f1cc

[Niu Yawei (Inactive)]

patch landed for 2.9