[LU-6929] typo in cfs_hash_for_each_relax() Created: 31/Jul/15  Updated: 19/Mar/19  Resolved: 18/Aug/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Critical
Reporter: Niu Yawei (Inactive) Assignee: Niu Yawei (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
is related to LU-6529 Server side lock limits to avoid unne... Closed
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

This is introduced in: fe60e0135ee2334440247cde167b707b223cf11d

+       if (start > 0 && rc != 0) {
+               end = start;
+               start = 0;
+               goto again;
+       }

I think it should be "if (start > 0 && rc == 0)", rc != 0 means caller want break the iteration.

 Comments   
Comment by Gerrit Updater [ 31/Jul/15 ]

Niu Yawei (yawei.niu@intel.com) uploaded a new patch: http://review.whamcloud.com/15813
Subject: LU-6929 libcfs: typo in cfs_hash_for_each_relax()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d1eb4612919b3e110603cf026c5c9b4a1b59ae37

Comment by Andreas Dilger [ 08/Aug/15 ]

Introduced in http://review.whamcloud.com/14931

Comment by Gerrit Updater [ 18/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15813/
Subject: LU-6929 libcfs: typo in cfs_hash_for_each_relax()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dcf045eb782a0660abf092796f3c316dc72721b8

Comment by Peter Jones [ 18/Aug/15 ]

Landed for 2.8

Generated at Sat Feb 10 02:04:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.