[LU-6938] zfs osd_xattr_list forgets to unlock a semaphore Created: 01/Aug/15  Updated: 03/Aug/15  Resolved: 03/Aug/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

It looks like we are forgetting an unlock in lustre/osd-zfs/osd_xattr.c::osd_xattr_list

        down(&obj->oo_guard);

        rc = osd_sa_xattr_list(env, obj, lb);
        if (rc < 0)
                GOTO(out, rc);
...
                if (lb->lb_buf != NULL) {
                        if (counted + rc + 1 > lb->lb_len)
                                RETURN(-ERANGE);
...
out:
        up(&obj->oo_guard);
        RETURN(rc);


 Comments   
Comment by Gerrit Updater [ 01/Aug/15 ]

Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: http://review.whamcloud.com/15828
Subject: LU-6938 osd: fix error handling in osd_xattr_list()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 52cda1aba1815fd5f274d61c255da34d4b3caf2c

Comment by Gerrit Updater [ 03/Aug/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15828/
Subject: LU-6938 osd: fix error handling in osd_xattr_list()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f5f05e31103eca016c59e392c520b24b607f807f

Comment by Peter Jones [ 03/Aug/15 ]

Landed for 2.8

Generated at Sat Feb 10 02:04:35 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.