[LU-6947] Stray comment in ptlrpc_start_pinger Created: 04/Aug/15 Updated: 27/Aug/15 Resolved: 27/Aug/15 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.8.0 |
| Type: | Bug | Priority: | Trivial |
| Reporter: | Oleg Drokin | Assignee: | Oleg Drokin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
There's this comment in ptlrpc_start_pinger: /* CLONE_VM and CLONE_FILES just avoid a needless copy, because we
* just drop the VM and FILES in kthread_run() right away. */
task = kthread_run(ptlrpc_pinger_main, &pinger_thread,
pinger_thread.t_name);
This does not make any sense anymore. Back when this was cfs_daemonize call, we did pass process flags there, but commit c8fd9c3c converted everything to kthread_ru that does not take any flags and so now this coment is totally out of place. A patch to remove it will be submitted shortly |
| Comments |
| Comment by Gerrit Updater [ 04/Aug/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/15838 |
| Comment by Joseph Gmitter (Inactive) [ 06/Aug/15 ] |
|
Assigning to Oleg - uploaded a patch already. |
| Comment by Gerrit Updater [ 26/Aug/15 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15838/ |
| Comment by Joseph Gmitter (Inactive) [ 27/Aug/15 ] |
|
Patch has landed for 2.8. |