[LU-6952] Mount options parsing problem

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.10.0
• Type: Bug
• Priority: Major
• Reporter: Rahul Deshmukh (Inactive)
• Assignee: Hongchao Zhang
• Resolution: Fixed
• Labels: cea, patch
• Severity: 3

Description

The code which parse the mount option (lustre/utils/mount_lustre.c: parse_ldd()) expect that the default mount options come first and then the user given options. But actually the default options are appended after the user given option. Because of this user given options are cleared.

Following code fix this bug:

diff --git a/lustre/utils/mount_lustre.c b/lustre/utils/mount_lustre.c
index e4cc51a..44d092c 100644
--- a/lustre/utils/mount_lustre.c
+++ b/lustre/utils/mount_lustre.c
@@ -385,6 +385,7 @@ static int parse_ldd(char *source, struct mount_opts *mop, char *options)
 {
        struct lustre_disk_data *ldd = &mop->mo_ldd;
        char *cur, *start;
+       char *temp_options;
        int rc;
 
        rc = osd_is_lustre(source, &ldd->ldd_mount_type);
@@ -438,12 +439,21 @@ static int parse_ldd(char *source, struct mount_opts *mop, char *options)
                        ldd->ldd_flags |= LDD_F_WRITECONF;
                }
        }
+
+       /* This is to make sure default options go first */
+       temp_options = strdup(options);
+       if (temp_options == NULL) {
+               fprintf(stderr, "can't allocate memory for temp_options\n");
+               return ENOMEM;
+       }
+       strcpy(options, ldd->ldd_mount_opts);
+       append_option(options, temp_options);
+       free(temp_options);
+
        /* backend osd type */
        append_option(options, "osd=");
        strcat(options, mt_type(ldd->ldd_mount_type));
 
-       append_option(options, ldd->ldd_mount_opts);
-
        if (!mop->mo_have_mgsnid) {
                /* Only use disk data if mount -o mgsnode=nid wasn't
                 * specified */

Issue Links

• is related to: LU-6662 mkfs should allow use of errors=panic

Comments

[Andreas Dilger]

Is there a reason why you posted the patch as a comment here instead of pushing a patch to Gerrit?

[Rahul Deshmukh (Inactive)]

Apology for any confusion. There is no perticular reason for this. Will post the patch to gerrit.

[Andreas Dilger]

It looks like the LU-6662 bug is very similar.

[Joseph Gmitter (Inactive)]

Hongchao,
This looks similar to your patch, can you look at it?
Thanks.
Joe

[Gerrit Updater]

pratik.shinde ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15906
Subject: LU-6952 mount: Mount options parsing problem
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0ebfd4c44c427628fd4928328582ad329c347c84

[Andreas Dilger]

Can you please check if http://review.whamcloud.com/15870 will also resolve this problem?

[Hongchao Zhang]

the patch http://review.whamcloud.com/15870 in LU-6992 can't resolve this problem, and I have refreshed the patch.

[Hongchao Zhang]

http://review.whamcloud.com/15906 has been updated

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/15906/
Subject: LU-6952 mount: Mount options parsing problem
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b27652cb440f2bea59db254e955403484c6c1d3a

[Peter Jones]

Landed for 2.10