[LU-6970] llog_osd_put_cat_list() leaks thandle after failed declaration

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Critical
• Reporter: John Hammond
• Assignee: Hongchao Zhang
• Resolution: Fixed
• Severity: 3

Description

This is in lustre-release/master as well. In llog_osd_put_cat_list() if dt_declare_record_write() fails then the thandle is never destroyed.

        th = dt_trans_create(env, d);
        if (IS_ERR(th))
                GOTO(out, rc = PTR_ERR(th));

        lgi->lgi_buf.lb_len = size;
        lgi->lgi_buf.lb_buf = idarray;
        rc = dt_declare_record_write(env, o, &lgi->lgi_buf, lgi->lgi_off, th);
        if (rc)
                GOTO(out, rc);
        ...
out_trans:
        dt_trans_stop(env, d, th);
out:
        lu_object_put(env, &o->do_lu);
        RETURN(rc);

Comments

[Andreas Dilger]

If this failure happens then the whole journal would be blocked waiting for this handle to be released, so it seems pretty serious.

[Joseph Gmitter (Inactive)]

Hongchao,
Can you look at this issue?
Thanks.
Joe

[Gerrit Updater]

Hongchao Zhang ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15951
Subject: LU-6970 llog: free thandle if declare failed
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1c155043793d9f7af22a2de01ee68fd914d24b3d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15951/
Subject: LU-6970 llog: free thandle if declare failed
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6fdcca8b2639ad9f6797cc7482da04c5e76a9e54

[Joseph Gmitter (Inactive)]

Landed for 2.8.