[LU-6995] incorrect use of bvec_iter_page in dio_complete_routine

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Frank Zago (Inactive)
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed
• Severity: 3

Description

bvec_iter_page is expecting a biovecs list as a first argument, not a biovec. That works as long as there is only one biovec in the bio. If there is more than one, then invalid memory is dereferences since bvl is a single vector, not a list. This only affect 3.14+ kernels, where HAVE_BVEC_ITER is true. Don't use bvec_iter_page, but create the right macro to simply return the vector's bv_page. Bug introduced in commit 833b670a.

Comments

[James A Simmons]

Yeah I have know about this bug for a while but never got around to fixing since I was busy with other task Thanks for picking this up.

[Gerrit Updater]

frank zago ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15967
Subject: LU-6995 osd: fix invalid use of bvec_iter_page
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6a57311a84ae1046588d6be2d2c3556dfc16f4d2

[Frank Zago (Inactive)]

No problem, James.

[Joseph Gmitter (Inactive)]

Hi Bob,
Can you have a look at the patch?
Thanks.
Joe

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15967/
Subject: LU-6995 osd: fix invalid use of bvec_iter_page
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: decbd1c0bfbc2d6c9e43c6fb880d7cbfe41b9143

[Peter Jones]

Landed for 2.8