[LU-7003] append_context_for_mount() must quote the value of the context option Created: 13/Aug/15 Updated: 27/Jan/17 Resolved: 14/Mar/16 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.5.0, Lustre 2.7.0, Lustre 2.8.0 |
| Fix Version/s: | Lustre 2.9.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | SELinux | ||
| Issue Links: |
|
||||
| Severity: | 3 | ||||
| Rank (Obsolete): | 9223372036854775807 | ||||
| Description |
|
In append_context_for_mount() the SELinux context of the temporary directory is appended to the mount options by strcat(mop->mo_ldd.ldd_mount_opts, ",context=");
strcat(mop->mo_ldd.ldd_mount_opts, fcontext);
This is incorrect since as mount.8 notes Warning: the context value might contain commas, in which case the value
has to be properly quoted, otherwise mount(8) will interpret the comma as
a separator between mount options. Don't forget that the shell strips
off quotes and thus double quoting is required. For example:
mount -t tmpfs none /mnt -o 'context="system_u:object_r:tmp_t:s0:c127,c456",noexec'
For more details, see selinux(8).
|
| Comments |
| Comment by Joseph Gmitter (Inactive) [ 13/Aug/15 ] |
|
John, |
| Comment by Gerrit Updater [ 04/Feb/16 ] |
|
Frederic Saunier (frederic.saunier@atos.net) uploaded a new patch: http://review.whamcloud.com/18294 |
| Comment by Gerrit Updater [ 14/Mar/16 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18294/ |