[LU-7025] lfsck_layout_scan_stripes suspicious rc assignment

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: nasf (Inactive)
• Resolution: Fixed
• Severity: 3

Description

We seem to be having this sort of code there:

                if (lso == NULL) {
                        struct lu_attr *attr = &info->lti_la;

                        rc = dt_attr_get(env, parent, attr);
                        if (rc != 0) {
                                rc = PTR_ERR(lso);
                                goto next;
                        }

Now note that lso is already NULL - meaning we reset nonzero rc into zero in quite a roundabout way.
Are you sure this is what was desired? I think we should just reuse the rc with the error instead?

Comments

[Gerrit Updater]

Fan Yong ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16042
Subject: LU-7025 lfsck: Invalid return value assignment
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 91b228fa7fc04884848c4e4fb3407881626266ea

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16042/
Subject: LU-7025 lfsck: Invalid return value assignment
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 604c7396b25c8e3a8e3ecf415d9f6f2bf1cbc6fd

[Joseph Gmitter (Inactive)]

Patch has landed for 2.8.