[LU-7027] Suspicios dereference in class_config_llog_handler Created: 20/Aug/15  Updated: 15/Jul/16  Resolved: 15/Jul/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In the class_config_llog_handler there's this code:

                if (clli->cfg_flags & CFG_F_EXCLUDE) {
                        CDEBUG(D_CONFIG, "cmd: %x marked EXCLUDED\n",
                               lcfg->lcfg_command);
                        if (lcfg->lcfg_command == LCFG_LOV_ADD_OBD)
                                /* Add inactive instead */
                                lcfg->lcfg_command = LCFG_LOV_ADD_INA;
                }

                lustre_cfg_bufs_init(&bufs, lcfg);

                if (clli && clli->cfg_instance &&
                    LUSTRE_CFG_BUFLEN(lcfg, 0) > 0){
...

So we dereference clli and then see if it was NULL? Does not sound right.

The upper part of code was added by Nathaniel in http://review.whamcloud.com/6197

 Comments   
Comment by Joseph Gmitter (Inactive) [ 21/Aug/15 ]

Hi Nathaniel,
Can you please look into this issue?
Thanks.
Joe

Comment by Nathaniel Clark [ 15/Jul/16 ]

This code was cleaned up by http://review.whamcloud.com/10420 (already landed to master)

Generated at Sat Feb 10 02:05:22 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.