[LU-7052] iovec created with iov_iter_get_pages_alloc must be freed with kvfree Created: 27/Aug/15  Updated: 23/Nov/15  Resolved: 27/Aug/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Frank Zago (Inactive) Assignee: WC Triage
Resolution: Won't Fix Votes: 0
Labels: patch

Issue Links:
Related
is related to LU-6260 more support for 3.16 linux kernel Resolved
is related to LU-7465 False positive memory leak in sanity ... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Commit 98883bd3e2cc48a3a5674ce140ad74bece37df05 added support for iov_iter_get_pages_alloc for newer kernels, instead of ll_get_user_pages. However the iovec was still freed within ll_free_user_pages, using OBD_FREE_LARGE. Use kvfree instead (like in the linux kernel).

 Comments   
Comment by Gerrit Updater [ 27/Aug/15 ]

frank zago (fzago@cray.com) uploaded a new patch: http://review.whamcloud.com/16111
Subject: LU-7052 llite: free iovec with kvfree
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 91b253a4385f2884bee5abad383555c4b33a3222

Comment by James A Simmons [ 27/Aug/15 ]

OBD_FREE thanks to LU-6587 handles freeing both vmalloc and kmalloc memory. It test if the memory in question was created with vmalloc. You will noticed OBD_FREE_LARGE is now a place holder for OBD_FREE.

Comment by Frank Zago (Inactive) [ 27/Aug/15 ]

Thanks James. So that patch is not needed for head of tree then.

That issue can be closed.

Comment by Peter Jones [ 27/Aug/15 ]

Hope I am understanding correctly that it is this ticket that can be closed

Generated at Sat Feb 10 02:05:35 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.