[#LU-709] Remove obsolete configure checks from {lustre,lnet,build}/autoconf/*.m4 and ldiskfs/configure.ac

OSD Misc feature landing tracker (LU-708) [LU-709] Remove obsolete configure checks from {lustre,lnet,build}/autoconf/*.m4 and ldiskfs/configure.ac Created: 22/Sep/11 Updated: 16/Apr/13 Resolved: 26/Sep/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.3.0, Lustre 2.4.0

Type:

Technical task

Priority:

Minor

Reporter:

Andreas Dilger

Assignee:

Yang Sheng

Resolution:

Fixed

Votes:

Labels:

None

Story Points:

Rank (Obsolete):

4526

Description

There are a large number of obsolete configure checks that are no longer needed and can be removed from the code. The client no longer needs to build against kernels older than 2.6.16 (SLES10), and all configure checks and conditional code related to this can be removed. On the server side, we will not be supporting anything older than RHEL5 (2.6.18) and even that may be removed and only RHEL6/SLES11SP1 supported (2.6.32) for the 2.2 release (not positive yet).

Rather than making a single large patch that deletes all of the obsolete checks and conditional code all over the kernel, it would be better to have a number of independent patches that can be inspected and landed separately, in case there is some controversy about one of the changes that would otherwise hold everything up.

It is possible to check which vanilla kernel a feature was added in via "git annotate

{filename}" and look for the line that has the relevant function, and the commit it was last changed in. Sometimes "git annotate -r {hash}~1 {filename}

" and/or "git show

{hash}" is needed to repeatedly check whether code was added or only modified in that commit. "git describe {hash}

" will give the most recent tag in which that commit was part of.

Some examples include:

LC_QUOTA_READ - has existed since 2.6.12:

$ git annotate include/linux/fs.h | grep "(\*quota_read)"
1da177e4	(Linus Torvalds	2005-04-16 15:20:36 -0700	1661)	ssize_t (*quota_read)(struct super_block *, int, char *, size_t, loff_t);
$ git describe 1da177e4
v2.6.12-rc2

means it was included before v2.6.12 was released.

LC_FUNC_F_OP_FLOCK, LC_COOKIE_FOLLOW_LINK, LC_PERCPU_COUNTER, LC_S_TIME_GRAN, etc. can likely all be removed, though the "RCU" conditional code should be left in. If any configure kernel-specific checks are found (as opposed to feature enable/disable) that do not have kernel versions, but are not being removed, please add a comment that indicates which kernel version is needed for.

Comments

Comment by Andreas Dilger [ 13/Jan/12 ]

Yang Sheng, can you please make some progress on cleaning up these old configure checks and the associated compatibility code. Most of these are trivial patches to generate, and it would help to remove a bunch of old compatibility code from Lustre and make it easier to understand.

Comment by Yang Sheng [ 13/Jan/12 ]

Sure, Andreas, The first patch is http://review.whamcloud.com/1916, I'll push more patches for this work.

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/lustre_eacl.h
lustre/utils/wiretest.c
lustre/include/liblustre.h
lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_acl.h
lustre/ptlrpc/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wirehdr.c
lustre/include/lustre_eacl.h
lustre/utils/wiretest.c
lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_acl.h
lustre/ptlrpc/wiretest.c
lustre/include/liblustre.h
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/linux/lustre_mds.h
lustre/ptlrpc/wirehdr.c
lustre/include/lustre_eacl.h
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/include/liblustre.h
lustre/include/linux/lustre_acl.h
lustre/include/lustre_mdc.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wiretest.c
lustre/include/liblustre.h
lustre/include/lustre_mdc.h
lustre/include/linux/lustre_acl.h
lustre/autoconf/lustre-core.m4
lustre/include/lustre_eacl.h
lustre/include/linux/lustre_mds.h
lustre/ptlrpc/wirehdr.c
lustre/utils/wiretest.c

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/linux/lustre_mds.h
lustre/include/liblustre.h
lustre/utils/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_acl.h
lustre/include/lustre_mdc.h
lustre/include/lustre_eacl.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/lustre_mdc.h
lustre/autoconf/lustre-core.m4
lustre/utils/wiretest.c
lustre/ptlrpc/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_mds.h
lustre/include/linux/lustre_acl.h
lustre/include/lustre_eacl.h
lustre/include/liblustre.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/include/lustre_eacl.h
lustre/include/linux/lustre_acl.h
lustre/ptlrpc/wirehdr.c
lustre/include/liblustre.h
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/autoconf/lustre-core.m4
lustre/include/lustre_eacl.h
lustre/include/liblustre.h
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_acl.h
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,server,el5,ofa #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_acl.h
lustre/include/liblustre.h
lustre/ptlrpc/wirehdr.c
lustre/include/lustre_mdc.h
lustre/utils/wiretest.c
lustre/include/lustre_eacl.h
lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_mds.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,client,el5,ofa #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/utils/wiretest.c
lustre/include/liblustre.h
lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_acl.h
lustre/include/lustre_mdc.h
lustre/include/lustre_eacl.h
lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_mds.h
lustre/ptlrpc/wirehdr.c

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/liblustre.h
lustre/autoconf/lustre-core.m4
lustre/ptlrpc/wiretest.c
lustre/include/lustre_mdc.h
lustre/include/linux/lustre_acl.h
lustre/utils/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/include/lustre_eacl.h
lustre/include/linux/lustre_mds.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/lustre_mdc.h
lustre/ptlrpc/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/autoconf/lustre-core.m4
lustre/utils/wiretest.c
lustre/include/linux/lustre_mds.h
lustre/include/liblustre.h
lustre/include/lustre_eacl.h
lustre/include/linux/lustre_acl.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/include/lustre_eacl.h
lustre/include/lustre_mdc.h
lustre/include/liblustre.h
lustre/include/linux/lustre_acl.h
lustre/autoconf/lustre-core.m4
lustre/utils/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/ptlrpc/wiretest.c
lustre/include/linux/lustre_mds.h

Comment by Build Master (Inactive) [ 16/Feb/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #476
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = SUCCESS
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_acl.h
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h
lustre/include/lustre_eacl.h
lustre/include/liblustre.h
lustre/utils/wiretest.c
lustre/ptlrpc/wiretest.c
lustre/autoconf/lustre-core.m4

Comment by Build Master (Inactive) [ 17/Feb/12 ]

Integrated in lustre-master » x86_64,server,el6,ofa #480
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = FAILURE
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/utils/wiretest.c
lustre/include/lustre_eacl.h
lustre/include/linux/lustre_mds.h
lustre/ptlrpc/wiretest.c
lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_acl.h
lustre/autoconf/lustre-core.m4
lustre/include/lustre_mdc.h
lustre/include/liblustre.h

Comment by Build Master (Inactive) [ 17/Feb/12 ]

Integrated in lustre-master » x86_64,client,el6,ofa #480
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = FAILURE
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/ptlrpc/wirehdr.c
lustre/include/linux/lustre_acl.h
lustre/autoconf/lustre-core.m4
lustre/include/lustre_eacl.h
lustre/utils/wiretest.c
lustre/include/linux/lustre_mds.h
lustre/include/lustre_mdc.h
lustre/ptlrpc/wiretest.c
lustre/include/liblustre.h

Comment by Build Master (Inactive) [ 17/Feb/12 ]

Integrated in lustre-master » i686,client,el6,ofa #480
~~LU-709~~ build: LC_XATTR_ACL & LC_POSIX_ACL_XATTR_H cleanup (Revision ac1b1940adc038b94fab1e201f8f7d362c711bf2)

Result = ABORTED
Oleg Drokin : ac1b1940adc038b94fab1e201f8f7d362c711bf2
Files :

lustre/utils/wiretest.c
lustre/ptlrpc/wiretest.c
lustre/autoconf/lustre-core.m4
lustre/include/linux/lustre_acl.h
lustre/include/lustre_mdc.h
lustre/include/linux/lustre_mds.h
lustre/include/lustre_eacl.h
lustre/include/liblustre.h
lustre/ptlrpc/wirehdr.c

Comment by Peng Tao [ 14/Mar/12 ]

patchsets to clean up lustre/autoconf/lustre-core.m4 are uploaded to gerrit. Please help to inspect.

~~LU-709~~ build: clean up LC_FUNC_GRAB_CACHE_PAGE_NOWAIT_GFP http://review.whamcloud.com/2326

~~LU-709~~ build: cleanup LC_LOCK_MAP_ACQUIRE and two used macr http://review.whamcloud.com/2325

~~LU-709~~ build: cleanup LC_FS_RENAME_DOES_D_MOVE/SPLICE_READ http://review.whamcloud.com/2324

~~LU-709~~ build: cleanup LC_PAGE_CHECKED and LC_INODE_BLKSIZE http://review.whamcloud.com/2323

~~LU-709~~ build: cleanup LC_FLUSH_OWNER_ID/INVALIDATE_MAPPING http://review.whamcloud.com/2322

~~LU-709~~ build: cleanup LC_SEQ_LOCK/FILEMAP_FDATAWRITE_RANGE http://review.whamcloud.com/2321

~~LU-709~~ build: cleanup VFS_KERN_MOUNT/INVALIDATEPAGE_RETURN_ http://review.whamcloud.com/2320

~~LU-709~~ build: clean up LC_NR_PAGECACHE/LC_STATFS_DENTRY_PAR http://review.whamcloud.com/2319

~~LU-709~~ build: clean up i_mutex/i_private/quota_info macros http://review.whamcloud.com/2318

~~LU-709~~ build: clean up percpu_counter and sb.s_time_gran http://review.whamcloud.com/2317

~~LU-709~~ build: clean up quota_read, follow_link and RCU http://review.whamcloud.com/2316

~~LU-709~~ build: clean up HAVE_CAN_SLEEP_ARG and HAVE_F_OP_FLO http://review.whamcloud.com/2315

~~LU-709~~ build: clean up LC_STRUCT_INTENT_FILE and LC_SUNRPC_ http://review.whamcloud.com/2314

~~LU-709~~ build: clean up four macros in lustre-core.m4 http://review.whamcloud.com/2313

Comment by Peng Tao [ 14/Mar/12 ]

patch to clean up lustre-lnet.m4 and ofed.m4

build: cleanup lustre-lnet.m4 and ofed.m4 http://review.whamcloud.com/2327

Comment by Peng Tao [ 14/Mar/12 ]

patch to clean up libcfs/autoconf/lustre-libcfs.m4

build: clean up libcfs/autoconf/lustre-libcfs.m4 http://review.whamcloud.com/2328