[LU-7134] Ensure ZFS hostid protection if servicenode/failover options given to mkfs.lustre Created: 10/Sep/15  Updated: 14/Jun/18  Resolved: 31/May/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.9.0

Type: Improvement Priority: Minor
Reporter: Nathaniel Clark Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: zfs

Issue Links:
Related
is related to LU-7797 Can't mount zpools after OSS restart Resolved
is related to LU-8816 test-framework needs to reload SPL mo... Resolved
is related to LU-3163 conf-sanity test_61 reformats MDT but... Resolved
is related to LU-6889 new kernel [SLES11 SP4 3.0.101-65] Resolved
Rank (Obsolete): 9223372036854775807

 Description   

SPL import protection only exists if hostid is set to a non-zero value. If servicenode or failover is given as an option, then mkfs.lustre should at least warn that hostid is set to zero and import protection won't work.

Proposed solution:

  • Have mkfs.lustre fail if --servicenode / --failover is specified and hostid is zero (will check spl_hostid value).
  • Add override option --force-nohostid to ignore this case

 Comments   
Comment by Nathaniel Clark [ 11/Sep/15 ]

SPL supports setting HostID in two ways:

option spl spl_hostid to manually specify the HostID to use
option spl spl_hostid_path to specify an alternate HostID file to use (default: /etc/hostid)

What if I check the spl hostid /sys/module/spl/parameters/spl_hostid to ensure it's non-zero? It show the HostID is is using (even when read from /etc/hostid)

Comment by Gerrit Updater [ 23/Sep/15 ]

Nathaniel Clark (nathaniel.l.clark@intel.com) uploaded a new patch: http://review.whamcloud.com/16611
Subject: LU-7134 utils: Ensure MMP support in SPL/ZFS during mkfs
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 15b26271b2ce4ccd87b424a75765edbf9f5f82eb

Comment by Nathaniel Clark [ 07/Dec/15 ]

Upon closer reading of the code in ZFS, I'm not sure enabling this will help in a fail-over scenario or provide adequate protection.

The code compares the host's hostid to the one written to the zpool and then prevents import if they don't match (unless one of the hostids is 0). This isn't true multi-mount protection. A more robust solution tracked in issue ZFS #745.

Comment by Gerrit Updater [ 31/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16611/
Subject: LU-7134 utils: Ensure hostid set for ZFS during mkfs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7b654fc673a2570ab4a828c2a7b213cee8b5b0cc

Comment by Peter Jones [ 31/May/16 ]

Landed for 2.9

Generated at Sat Feb 10 02:06:17 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.