[LU-7160] Saved by change_nids .bak files on MGS should never be processed

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Minor
• Reporter: Artem Blagodarenko (Inactive)
• Assignee: WC Triage
• Resolution: Fixed
• Labels: patch
• Severity: 3

Description

lctl replace_nids command saves previous version of
config files to file with original_name.bak file name.
This file should never be processed by MGS.

This patch adds code that skips file with .bak extention
from list to be processed by MGS.

Issue Links

• is related to: LU-10883 llog backup files processing is not s...
• is related to: LU-11648 Create white list for CONFIGS directo...

Comments

[Gerrit Updater]

Artem Blagodarenko ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16428
Subject: LU-7160 mgs: Skip processing .bak files on MGS
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e0451cd7e0f6044a48d6f592932c63528fa21f05

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16428/
Subject: LU-7160 mgs: Skip processing .bak files on MGS
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0bb49b2624827490ca3ea6a146d96cf7cf2b402f

[Peter Jones]

Landed for 2.9

[Andreas Dilger]

As mentioned in my review of http://review.whamcloud.com/16428/ I think this patch could be more robust. In addition to .bak files, I've personally made backup files of the form myth-MDT0000-20160811 before doing some major system change. Having the lctl replace_nids code change the NIDs in all of the backup files it finds kind of breaks the value of having backups in the first place...

It would be more robust if the replace_nids code checked for specific filenames like fsname-<OST,MDT>nnnn and fsname-client and only modified those files instead of changing every file that it finds in CONFIGS/.

[Andreas Dilger]

Fan Yong,
does a similar problem exist with the rename filesystem patch http://review.whamcloud.com/18597 ?

[nasf (Inactive)]

Currently, the tools for rename filesystem name can filter out the names with "-" as postfix, such as "myth-MDT0000-20160811", after merging with the patch http://review.whamcloud.com/16428/, it also can filter out the names with ".bak" as postfix. As for other format, such as "myth-MDT0000.2016", it will not be filtered out.

[Artem Blagodarenko (Inactive)]

> I've personally made backup files of the form myth-MDT0000-20160811 before doing some major system change
Andreas, probably storing backup files outside the Lustre FS is the best solution. This is more safe for files and for Lustre FS. If you store something (files that not used by Lustre FS) in config directory - no warranty.
Another solution - store automatic backup files (from replace_nids for example) to other directory, not CONFIGS.