[LU-725] dead code in ll_direct_rw_pages()

• Status: Closed
• Project: Lustre
• Affects Version/s: Lustre 2.1.0
• Type: Bug
• Priority: Minor
• Reporter: Johann Lombardi (Inactive)
• Assignee: Jinshan Xiong (Inactive)
• Resolution: Fixed
• Severity: 3

Description

ssize_t ll_direct_rw_pages(const struct lu_env *env, struct cl_io *io,
                           int rw, struct inode *inode,
                           struct ll_dio_pages *pv)
{
        ...
        for (i = 0; i < page_count; i++) {
                ...
                clp = cl_page_find(env, obj, cl_index(obj, file_offset),
                                   pv->ldp_pages[i], CPT_TRANSIENT);
                ...
                rc = cl_page_own(env, io, clp);
                ...
                /* check the page type: if the page is a host page, then do
                 * write directly */
                if (clp->cp_type == CPT_CACHEABLE) {
------------------------> since transient pages are not stored in the radix tree
                          any more, all the code under this if statement is now useless.

Comments

[Jinshan Xiong (Inactive)]

The work is already in Lustre.