|
Is there a need for storing the security.* xattrs, or is that not appropriate for ChangeLog users?
Should the code that decides which xattrs types to add to the ChangeLog in mdd_xattr_set() and mdd_xattr_del() and their *_declare() functions be abstracted into a helper function like mdd_xattr_needs_changelog() or similar so that we don't have multiple checks spread throughout the code? Otherwise, as LU-6886 showed, it seems too easy that these checks will again become inconsistent in the future. It is already true that mdd_declare_xattr_set() calls mdd_declare_changelog_store() for every xattr type, but mdd_xattr_set() only records specific xattrs into the ChangeLog. While not harmful, this adds unnecessary overhead to the transaction and would also be fixed by unifying the checks for which xattr changes are being logged.
|
|
It would definitely be valuable to have changelog records for security.*, trusted.*, user.* (already in place) and system.* (i.e. everything but lustre-specific xattrs). The list of desired classes could be controlled from a procfs entry (similar to the changelog mask).
|