[LU-7276] llog_reader doesn't process CM_SKIP records like the kernel Created: 09/Oct/15  Updated: 19/Jan/16  Resolved: 19/Jan/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.5.3, Lustre 2.8.0
Fix Version/s: Lustre 2.8.0

Type: Bug Priority: Minor
Reporter: Andreas Dilger Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The llog_reader command doesn't process the CM_SKIP records in config log LCFG_MARKER records same manner that the kernel does, which can result in misleading output in some cases. In particular, llog_reader will report SKIP for all records between CM_START|CM_SKIP and CM_END|CM_SKIP, but the kernel stops skipping records at the first CM_END record regardless of whether or not there is a CM_SKIP there, and definitely not into the subsequent configuration stanzas.



 Comments   
Comment by Gerrit Updater [ 09/Oct/15 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/16788
Subject: LU-7276 utils: make llog_reader consistent with kernel
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 329569a781442ab3c0c93e268fc5bd9cd85ee205

Comment by Gerrit Updater [ 30/Nov/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16788/
Subject: LU-7276 utils: make llog_reader consistent with kernel
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3041bbc4409572831c36b6e2e36922b886a0685b

Comment by Joseph Gmitter (Inactive) [ 30/Nov/15 ]

Landed for 2.8

Comment by Gerrit Updater [ 16/Dec/15 ]

Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: http://review.whamcloud.com/17627
Subject: LU-7276 utils: fix llog_reader loop on empty log
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 327bfe9739ca2c6fc15994cc86557b26d474ed48

Comment by Andreas Dilger [ 22/Dec/15 ]

Another patch to be landed.

Comment by Gerrit Updater [ 18/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17627/
Subject: LU-7276 utils: fix llog_reader loop on empty log
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ade3d1ee9494af32f4e022e30757318a94b7ee96

Comment by Joseph Gmitter (Inactive) [ 19/Jan/16 ]

Both patches are now landed for 2.8.0

Generated at Sat Feb 10 02:07:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.