[LU-7299] allow mkfs.lustre --index to be specified in hex Created: 14/Oct/15  Updated: 13/Feb/16  Resolved: 28/Oct/15

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0

Type: Improvement Priority: Minor
Reporter: Andreas Dilger Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: easy, patch

Issue Links:
Related
is related to LU-2475 Improve the documentation of the "--i... Resolved
Rank (Obsolete): 9223372036854775807

 Description   

The mkfs.lustre --index argument should be able to handle hex index values as well as decimal values, especially since the OSTxxxx identifiers are printed in hexadecimal as well.

The current code uses atol() currently, but should be changed to strtoul(,,0) so that it can also accept index values of the form 0xnnnn and handle better error checking.



 Comments   
Comment by Andreas Dilger [ 14/Oct/15 ]

This change should also be documented in the mkfs.lustre(8) man page.

Comment by Gerrit Updater [ 15/Oct/15 ]

Thomas Stibor (t.stibor@gsi.de) uploaded a new patch: http://review.whamcloud.com/16831
Subject: LU-7299 utils: allow mkfs.lustre --index to specify in hex/dec
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: bb233adaa34689930cf0038877589a9a6c588db0

Comment by Andreas Dilger [ 15/Oct/15 ]

Thomas, thanks for the patch.

Comment by Gerrit Updater [ 28/Oct/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16831/
Subject: LU-7299 utils: allow mkfs.lustre --index to specify in hex/dec
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 069a25b61ecdfc7b01edfa302ff49b1a6897928a

Comment by Joseph Gmitter (Inactive) [ 28/Oct/15 ]

Landed for 2.8

Generated at Sat Feb 10 02:07:41 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.