[LU-7317] error function not called upon error

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.9.0
• Type: Bug
• Priority: Trivial
• Reporter: Aditya Pandit (Inactive)
• Assignee: James Nunez (Inactive)
• Resolution: Fixed
• Severity: 3

Description

$ grep '|| \"' ./*.sh -r

./replay-ost-single.sh: $SETSTRIPE -i 0 -c 1 $DIR/$tfile || "setstripe failed"
./sanity-hsm.sh: dd if=$file2 of=/dev/null bs=1M || "cannot read '$file2'"
./sanity-lfsck.sh: [ $count2 -eq 2 ] || "(6) Fail to inject error: $count2"
./sanity-lfsck.sh: stat $DIR/$tdir/foo/f0 || "(18) f0 is not recovered"
./sanityn.sh: mv $DIR2/$tdir/d1/0 $DIR2/$tdir/d0/0 || "rename d1/0 d0/0 failed"
./sanity-quota.sh: set_ost_qtype "ug" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "ug" || "enable mdt quota failed"
./sanity-quota.sh: $RUNAS unlinkmany $TESTFILE $ilimit || "unlink files failed"
./sanity-quota.sh: $RUNAS unlinkmany $TESTFILE $((ilimit + 1)) || "unlink failed"
./sanity-quota.sh: rmdir $DIR/${tdir}-1 || "unlink remote dir failed"
./sanity-quota.sh: set_ost_qtype "ug" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "ug" || "enable mdt quota failed"
./sanity-quota.sh: set_ost_qtype "u" || "enable ost quota failed"
./sanity-quota.sh: set_mdt_qtype "u" || "enable mdt quota failed"
./sanity-quota.sh: set_ost_qtype "u" || "enable ost quota failed"
./sanity.sh: touch ${testdir}/${tfile} || "touch failed"
./sanity.sh: mknod ${testdir}/${tfile}-pipe p || "mknod failed"
./sanity.sh: rm -f ${testdir}/${tfile}-pipe || "pipe remove failed"
./sanity.sh: touch ${testdir}/${tfile} || "touch failed"
./sanity.sh: [ $unused -eq 0 ] || "$unused locks are not cleared"
./sanity.sh: do_facet ost1 "lsmod | grep -q obdecho || " \
./sanity.sh: "{ insmod ${LUSTRE}/obdecho/obdecho.ko || " \
./sanity.sh: rm -r $DIR/$tdir || "AGL for rmdir failed"

Everywhere it should have error "<string>"

Comments

[Gerrit Updater]

aditya.pandit ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16888
Subject: LU-7317 tests: Called the error function where it was missing.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ac7c03cd12a0f3f00a133b0e0ffabe74fd6c2bfc

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16888/
Subject: LU-7317 tests: Called the error function where it was missing.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 87e1428b792ad2a2a49db71924438a37a4537e6a

[Joseph Gmitter (Inactive)]

Landed to master for 2.9.0