[LU-737] can not attach device name starting with a digit

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.2.0, Lustre 1.8.7
• Fix Version/s: Lustre 2.2.0, Lustre 1.8.8
• Type: Improvement
• Priority: Minor
• Reporter: Minh Diep
• Assignee: Minh Diep
• Resolution: Fixed

Description

If we assign fsname starting with a digit (ie 1b), the OST devices name will be 1b-OST0000 and this will prevent lctl to work, see below

[root@fat-amd-1 ~]# lctl dl
0 UP mgs MGS MGS 5
1 UP mgc MGC10.10.4.132@tcp 299348e4-2002-b4b5-3a43-44db755a662a 5
2 UP mdt MDS MDS_uuid 3
3 UP lov 1b-mdtlov 1b-mdtlov_UUID 4
4 UP mds 1b-MDT0000 1b-MDT0000_UUID 3
5 UP ost OSS OSS_uuid 3
6 UP obdfilter 1b-OST0000 1b-OST0000_UUID 5
7 UP osc 1b-OST0000-osc 1b-mdtlov_UUID 5
8 AT echo_client 1b-OST0000_ecc 1b-OST0000_ecc_UUID 1
[root@fat-amd-1 ~]# lctl
lctl > device 1b-OST0000_ecc
lctl > cleanup
cleanup: please use 'device name' to set the device name for config commands.
lctl >

I also found out that lustre fsname can be anything except ":". is this a good idea? should we restrict it to unix name format (alpha, number, _)?

Comments

[Robert Read (Inactive)]

We should first see if we can fix the "is it a name or number" code in lctl to be a lot smarter.

[Minh Diep]

fix available at http://review.whamcloud.com/#change,1641

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el5,ofa #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,ofa #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,el6,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el6,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,client,ubuntu1004,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,client,el5,inkernel #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » x86_64,server,el5,ofa #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-b1_8 » i686,server,el5,ofa #157
LU-737 utils: check device name for digit (Revision 8089ee261a08a1bc38c214c90edae08e71cd7727)

Result = SUCCESS
Johann Lombardi : 8089ee261a08a1bc38c214c90edae08e71cd7727
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #359
LU-737 utils: check device name for digit (Revision 0979faacdb3e7e9112d1b29006dc4f78182360a9)

Result = SUCCESS
Oleg Drokin : 0979faacdb3e7e9112d1b29006dc4f78182360a9
Files :

• lustre/utils/lustre_cfg.c

[Minh Diep]

Landed on both b1_8 and master, closing