[LU-7403] lookup_intent handling is obscure Created: 06/Nov/15  Updated: 22/Jun/16  Resolved: 22/Jun/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The handling of the members of struct lookup_intent is obscure. There is a pointless union, void *it_data should be struct ptlrpc_request *it_request. The lock cookies are __u64 rather than struct lustre_handle. We do not use const qualifiers on function parameters where we should.

 Comments   
Comment by Gerrit Updater [ 06/Nov/15 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/17069
Subject: LU-7403 llite: flatten struct lookup_intent
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9971c1b2b0e5de7c5bc17d3642eb86e66c1796fb

Comment by Gerrit Updater [ 06/Nov/15 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/17070
Subject: LU-7403 llite: change it_data to it_request
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f32a7a86ae6a5162dcc2a9a18d46d12966bfb2dd

Comment by Gerrit Updater [ 06/Nov/15 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/17071
Subject: LU-7403 dlm: const qualify struct lustre_handle * params
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 48312a3596034ed7826db78e5ecf2c3e96699453

Comment by Gerrit Updater [ 06/Nov/15 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/17072
Subject: LU-7403 obd: const correct md_set_lock_data()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7be6da0cff7af306707c50bb4e7398d97bd652fe

Comment by Joseph Gmitter (Inactive) [ 06/Nov/15 ]

Assigning to John as there is already a patch in flight

Comment by Gerrit Updater [ 02/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17069/
Subject: LU-7403 llite: flatten struct lookup_intent
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5db0e2de00f6b3d687fc4fe01f05a687fc74271c

Comment by Gerrit Updater [ 21/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17070/
Subject: LU-7403 llite: change it_data to it_request
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 40b5a643d51b678b7a0e9970c80740cea04b4837

Comment by Gerrit Updater [ 21/May/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17071/
Subject: LU-7403 dlm: const qualify struct lustre_handle * params
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 97fe58c7ec2b5c88c4ecbc2e3597317792d985d6

Comment by Gerrit Updater [ 22/Jun/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17072/
Subject: LU-7403 obd: const correct md_set_lock_data()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: dd6623e657032bf34e70446a6d72851c70d605d9

Comment by Joseph Gmitter (Inactive) [ 22/Jun/16 ]

All patches have landed to master for 2.9.0

Generated at Sat Feb 10 02:08:36 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.