[LU-7501] inconsistencies between "lfs find", "lfs getstripe", "lfs setstripe", "lfs setdirstripe"

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.9.0, Lustre 2.11.0
• Type: Bug
• Priority: Minor
• Reporter: Andreas Dilger
• Assignee: Yang Sheng
• Resolution: Fixed
• Labels: dne3
• Severity: 3

Description

There are a number of inconsistencies in the command-line options between lfs find, lfs getstripe, and lfs setstripe/lfs migrate which are confusing and should be fixed, in a compatible manner, but deprecating the old options.

• lfs find and lfs migrate use -m to for mdt_index, but lfs getstripe uses -M to indicate mdt_index. getstripe should use -m and deprecate -M, since find uses -M for mtime.
• lfs setstripe uses --ost-list, but lfs find and lfs getstripe uses for --ost, but they are all conceptually the same thing. setstripe should just use --ost for this, and deprecate --ost-list as this option has only been around for a short time.
• lfs find uses --mdt to search for a specific mdt_index, but lfs getstripe and lfs migrate use --mdt-index. find should add --mdt-index (and --mdt_index for ease of use, but not document it), and getstripe and migrate should add --mdt.

I'm not sure of a clear winner between --mdt and --mdt-index, since I don't think --mdt is confusing and it parallels --ost for OST selection, and is short and convenient. Having both is not harmful I think.

The lfs setdirstripe and lfs getdirstripe options should also be expanded to be consistent with those in lfs find and lfs getstripe, namely, add --mdt-count|-c, --mdt-index|-m, --mdt-hash as aliases for the existing --count|-c and --index|-i and --hash-type|-t options. The long -count and -index options should be deprecated with LUSTRE_VERSION_CODE checks as they were for lfs_setstripe().

Issue Links

• is duplicated by: LU-9378 extract lfs-getstripe.1 from lfs.1
• is related to: LU-7502 add lfs find --mdt-count and --mdt-ha...
• is related to: LU-7503 "-v" is missing for "lfs migrate -m"
• is related to: LU-10856 running sanity now prints "warning: '...
• is related to: LU-11891 make --mdt-index usage consistent
• is related to: LU-15276 DNE3: "lfs find" able to check defaul...

Comments

[Peter Jones]

Yang Sheng

Could you please investigate?

THanks

Peter

[Andreas Dilger]

Yang Sheng, could you please take some time to make a patch for this issue.

[Yang Sheng]

Hi, Andreas,

I'll produce a patch for it asap.

Thanks,
YangSheng

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: http://review.whamcloud.com/22581
Subject: LU-7501 utils: keep lfs arguments consistently
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: de2f76c2120e36cb761574513d827c681f73416f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/22581/
Subject: LU-7501 utils: keep lfs arguments consistent
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cdeb2f3a56e89941e6af0c83929617ed52b8cb7a

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/30464
Subject: LU-7501 utils: split getstripe and find from lfs.1
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5e8c89444161033384b96c6bc1e6d953903a698e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28592/
Subject: LU-7501 utils: clean up lfs argument handling/docs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5fee5b700d1e683d165fc0ef0ae88c2a0ab83681