[LU-7589] update checkpatch.pl from upstream kernel Created: 21/Dec/15 Updated: 07/Nov/18 Resolved: 29/Jul/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Andreas Dilger | Assignee: | James A Simmons |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
Based on comments made in http://review.whamcloud.com/17661 to follow the upstream kernel coding style, it makes sense to update contrib/scripts/checkpatch.pl with recent upstream changes so that it follows current kernel CodingStyle, since changes like "printk strings allowed over 80 chars" that are in conflict to what our current checkpatch.pl complains about. Also the "if (rc == NULL)" and "if (rc != 0)" are deprecated upstream. However, we also have local checkpatch.pl modifications to complain about typedefs and cfs_ wrappers and such, so that shouldn't be removed. Possibly hooked into a more "vanilla" checkpatch.pl and the Lustre-specific deprecations in an external file? |
| Comments |
| Comment by James A Simmons [ 11/Jan/16 ] |
|
Yeah, my first ticket. |
| Comment by James A Simmons [ 20/Jul/17 ] |
| Comment by Gerrit Updater [ 29/Jul/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/28055/ |