[LU-761] Return values of ll_prep_md_op_data() should be checked using IS_ERR(). Created: 13/Oct/11  Updated: 12/Dec/11  Resolved: 12/Dec/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.1.0
Fix Version/s: Lustre 2.2.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 4813

 Description   

Several places test to see if ll_prep_md_op_data() returned NULL. Others assume all errors are due to out of memory. Still other's dont check it at all when they should.

 Comments   
Comment by John Hammond [ 13/Oct/11 ]

http://review.whamcloud.com/1520

Comment by Peter Jones [ 12/Dec/11 ]

Landed for 2.2

Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/file.c
  • lustre/llite/dir.c
  • lustre/llite/llite_nfs.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/dir.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/file.c
  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/llite_lib.c
  • lustre/llite/dir.c
  • lustre/llite/file.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/llite_nfs.c
  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/dir.c
  • lustre/llite/file.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/llite_nfs.c
  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/file.c
  • lustre/llite/dir.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/dir.c
  • lustre/llite/file.c
  • lustre/llite/llite_lib.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/symlink.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/file.c
  • lustre/llite/dir.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/file.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/dir.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el5,ofa #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/file.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/dir.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/llite_lib.c
  • lustre/llite/dir.c
  • lustre/llite/file.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = FAILURE
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/file.c
  • lustre/llite/symlink.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/llite_lib.c
  • lustre/llite/dir.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/llite_lib.c
  • lustre/llite/dir.c
  • lustre/llite/file.c
  • lustre/llite/symlink.c
  • lustre/llite/llite_nfs.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/llite_lib.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/dir.c
  • lustre/llite/symlink.c
  • lustre/llite/file.c
Comment by Build Master (Inactive) [ 12/Dec/11 ]

Integrated in lustre-master » i686,server,el5,ofa #378
LU-761: Check return of ll_prep_md_op_data() using IS_ERR(). (Revision bd495258d54ea5ab5be7aee4ea23fae558e2f8c4)

Result = SUCCESS
Oleg Drokin : bd495258d54ea5ab5be7aee4ea23fae558e2f8c4
Files :

  • lustre/llite/symlink.c
  • lustre/llite/llite_lib.c
  • lustre/llite/llite_nfs.c
  • lustre/llite/file.c
  • lustre/llite/dir.c
Generated at Sat Feb 10 01:10:10 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.