[LU-7623] Clean up lustre user/kernel pointer types. Created: 02/Jan/16  Updated: 13/Dec/16  Resolved: 11/Feb/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.8.0, Lustre 2.9.0

Type: Bug Priority: Major
Reporter: Oleg Drokin Assignee: Oleg Drokin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-6215 Sync Lustre external tree with lustre... Resolved
is related to LU-7624 fld_proc_hash_seq_write accesses user... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Currently there's a significant mess in Lustre code in regards to kernel/user pointers.
Structures are not separated and could be used from both which is bad for multiple reasons.
This also makes it hard for various static tools to properly enforce access rules.

Things like IOC_LIBCFS_DEBUG_PEER "ioctl" should be cleaned out and the __user modifiers added all around in the structures to make everything work nice and well.

 Comments   
Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17778
Subject: LU-7623 lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 12be094e57b485c684a23455fba984b1abed87ee

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17788
Subject: LU-7623 Add __user to seq_write buffer arguments
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8d599c1f58a98ca4fe2316829745f539c6ff96a6

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17789
Subject: LU-7623 mdt: Match up prototype and definition of mdt_hsm_cdt_control_seq_write
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 05d391314499a38d558782964d8bd4c429a994b6

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17790
Subject: LU-7623 gss: Update upcall structure with user attributes
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e4363a5c80b280e161d482d08beb8d614754aad7

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17779
Subject: LU-7623 lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 82e735fd82916802c4438a34806799a6d9ffc992

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17780
Subject: LU-7623 lov: Get rid of an ugly statfs hack in lov_iocontrol
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 166b551b8ab4e8f8b5575bde28e3c2ead6d68d5a

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17781
Subject: LU-7623 Update obd iocontrol methods with __user attribute
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: eb910fba9f7aaa047f5ed1e34d6cda69c7653935

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17782
Subject: LU-7623 lmv: Properly mark lmv_fid2path uarg argment as __user
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8ddfdef6105caaf47ac9001d7f360581a386470c

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17783
Subject: LU-7623 lmv: Mark lmv_hsm_ct_register/unregister uarg as __user
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 452dc42c7ce3976e8752bcdd2c078c55a4d6ecaa

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17784
Subject: LU-7623 lnet: Properly declare lnet_ping() forward declaration
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3588a998f5ee2f1d448df75cbece1b70da318d73

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17785
Subject: LU-7623 lnet: Remove __user attribute from lnet_copy_flat2* functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e39d05d9c2c4dcdabdc8543baa58ef9ff34d89a7

Comment by Gerrit Updater [ 04/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/17787
Subject: LU-7623 libcfs: Properly map page for vfs_write
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 22e20be216a29b85557ab28dea1031c806374021

Comment by Gerrit Updater [ 07/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17790/
Subject: LU-7623 gss: Update upcall structure with user attributes
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 305bd3d8c82c4ecf67a8d53f43ae69e9cb5568e7

Comment by Gerrit Updater [ 07/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17785/
Subject: LU-7623 lnet: Remove __user attribute from lnet_copy_flat2* functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4594c003e9aa63bde006908e34834a8c134b305c

Comment by Gerrit Updater [ 07/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17787/
Subject: LU-7623 libcfs: Properly map page for vfs_write
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e2a442e3288afec9450a9aef188fe38dce35aab0

Comment by Gerrit Updater [ 07/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17788/
Subject: LU-7623 Add __user to seq_write buffer arguments
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6fc8da41f2ff5156639e89f379adcdbb73ac8567

Comment by Gerrit Updater [ 28/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17778/
Subject: LU-7623 lnet: Get rid of IOC_LIBCFS_DEBUG_PEER hack
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39160ccc60eb88c4a665d5d129abceacd2860de2

Comment by Gerrit Updater [ 28/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17779/
Subject: LU-7623 lnet: Get rid of IOC_LIBCFS_PORTALS_COMPATIBILITY ioctl
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9bafa64985cae09eee5adaba5725038df1bf12e3

Comment by Gerrit Updater [ 28/Jan/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17780/
Subject: LU-7623 lov: Get rid of an ugly statfs hack in lov_iocontrol
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9281658095a63c88a12246df5fb6f3b78f97095a

Comment by Gerrit Updater [ 05/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17781/
Subject: LU-7623 Update obd iocontrol methods with __user attribute
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9175d6f862039cfbf6b85333d72a9d91e64ea42a

Comment by Gerrit Updater [ 05/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17782/
Subject: LU-7623 lmv: Properly mark lmv_fid2path uarg argment as __user
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: bdd1272607a95482d6b5261de7fe8bec1d57e2a8

Comment by Gerrit Updater [ 05/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17783/
Subject: LU-7623 lmv: Mark lmv_hsm_ct_register/unregister uarg as __user
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 3b2dad4ebb4ac81cebeab6c7e0c4ecb67f1de7ea

Comment by Gerrit Updater [ 05/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17784/
Subject: LU-7623 lnet: Properly declare lnet_ping() forward declaration
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 115011c524e8674de010ddd2dea4afb497c1884e

Comment by Gerrit Updater [ 05/Feb/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17789/
Subject: LU-7623 mdt: Match up prototype and definition of mdt_hsm_cdt_control_seq_write
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f5f3725d43b30ea9af3928ebb5bfd6fdc2c5c964

Comment by James A Simmons [ 11/Feb/16 ]

All patches have landed.

Comment by Gerrit Updater [ 16/Mar/16 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: http://review.whamcloud.com/18950
Subject: LU-7623 lnet: remove useless cast
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d6a8c4abea6f0c7e5e9d2cb6547cb92319f0e282

Comment by Gerrit Updater [ 05/Jul/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18950/
Subject: LU-7623 lnet: remove useless cast
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ba162203853721dd2ad16bcc2212b11461974264

Generated at Sat Feb 10 02:10:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.