[LU-7627] Lustre sanity tests 130b, 130c, 130d, and 130e have a faulty comparison that causes them to fail Created: 04/Jan/16  Updated: 29/May/17  Resolved: 14/Mar/16

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.8.0
Fix Version/s: Lustre 2.9.0

Type: Bug Priority: Major
Reporter: VIKRAM BABASO JADHAV (Inactive) Assignee: James Nunez (Inactive)
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Duplicate
is duplicated by LU-1862 OST_COUNT > 10 will make some sanity ... Resolved
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Test 130c-130e failures are all the same coding issue, where a comparison is done on two hex numbers without prefacing them with '0x' so that they are treated as hex:
test 130b:
7178 if (( $frag_lun != $last_lun )); then
should be
7178 if (( 0x$frag_lun != 0x$last_lun )); then
test 130c:
7227 if (( $frag_lun != $last_lun )); then
should be:
7227 if (( 0x$frag_lun != 0x$last_lun )); then
test 130d:
7282 if (( $frag_lun != $last_lun )); then
should be
7282 if (( 0x$frag_lun != 0x$last_lun )); then
test 130e:
7336 if (( $frag_lun != $last_lun )); then
should be
7336 if (( 0x$frag_lun != 0x$last_lun )); then

Tests 130[bcde] failed because numbers parsed with leading zeros
treated as octal number so there is error value too great for base
when parsed lun id greater than 0007 value,



 Comments   
Comment by Gerrit Updater [ 04/Jan/16 ]

jadhav.vikram (jadhav.vikram@seagate.com) uploaded a new patch: http://review.whamcloud.com/17794
Subject: LU-7627 tests: parse filefrag output correctly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: fc01785cc0f3ffafcbaaf4a9baf766455f629123

Comment by Gerrit Updater [ 14/Mar/16 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/17794/
Subject: LU-7627 tests: parse filefrag output correctly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 54b8a86387539200fd214e0d4ee951cf7e772e5f

Generated at Sat Feb 10 02:10:32 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.