[LU-7628] bad NULL pointer check in cb_migrate_mdt_init()

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.8.0
• Fix Version/s: Lustre 2.8.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: Emoly Liu
• Resolution: Fixed
• Labels: llapi
• Severity: 3

Description

At the end of cb_migrate_mdt_init(), after calling opendir() we should test *dirp rather than dirp:

out:
        if (dirp != NULL) {
                /* If the directory is being migration, we need
                 * close the directory after migration,
                 * so the old directory cache will be cleanup
                 * on the client side, and re-open to get the
                 * new directory handle */
                *dirp = opendir(path);
		if (dirp == NULL) {
                        ret = -errno;
                        llapi_error(LLAPI_MSG_ERROR, ret,
                                    "%s: Failed to open '%s'", __func__, path);
			return ret;
                }
        }

        if (parent == NULL)
                closedir(dir);

        return ret;

We also may leak dir on early return but the logic of this function is so convoluted that it's hard to tell.

Comments

[Gerrit Updater]

Emoly Liu ([e-mail]) uploaded a new patch: http://review.whamcloud.com/17814
Subject: LU-7628 lfs: fix NULL pointer check in cb_migrate_mdt_init()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6cad5b0ed6b49dfd61c6c702f9ff3b70df182347

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17814/
Subject: LU-7628 lfs: fix NULL pointer check in cb_migrate_mdt_init()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39fe7d2ef4da9bcfc2f9113c7c2ea45fcf93450e

[Emoly Liu]

Landed for 2.8.0